public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: Jan Tulak <jtulak@redhat.com>
Cc: fstests@vger.kernel.org, david@fromorbit.com
Subject: Re: [PATCH 4/4] xfstests: filename handling - fix early wildcard expansion
Date: Wed, 13 Jul 2016 20:28:59 +0800	[thread overview]
Message-ID: <20160713122859.GV2432@eguan.usersys.redhat.com> (raw)
In-Reply-To: <1468229169-24045-5-git-send-email-jtulak@redhat.com>

On Mon, Jul 11, 2016 at 11:26:09AM +0200, Jan Tulak wrote:
> Add quotation marks around the wildcarded name.

This makes no difference for me, the original code is working well. Did
I miss anything?

[root@dhcp-66-86-11 xfstests]# bname=999
[root@dhcp-66-86-11 xfstests]# find tests/xfs -name "$bname*"
tests/xfs/999-test-case
tests/xfs/999-test-case.out
[root@dhcp-66-86-11 xfstests]# find tests/xfs -name $bname*
tests/xfs/999-test-case
tests/xfs/999-test-case.out

Thanks,
Eryu

> 
> Signed-off-by: Jan Tulak <jtulak@redhat.com>
> ---
>  check | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/check b/check
> index 58d8869..5ff897b 100755
> --- a/check
> +++ b/check
> @@ -548,7 +548,7 @@ for section in $HOST_OPTIONS_SECTIONS; do
>  	        # and the test has a name. A bit of hassle to find really
>  	        # the test and not its sample output or helping files.
>  	        bname=$(basename $seq)
> -	        full_seq=$(find $(dirname $seq) -name $bname* -executable |
> +	        full_seq=$(find $(dirname $seq) -name "$bname*" -executable |
>  	            awk '(NR == 1 || length < length(shortest)) { shortest = $0 }\
>  	            	END { print shortest }')
>  	        if [ -f $full_seq ] \
> -- 
> 2.5.5
> 

  reply	other threads:[~2016-07-13 12:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-11  9:26 [PATCH 0/4 v2] xfstests: extended names fixes Jan Tulak
2016-07-11  9:26 ` [PATCH 1/4] xfstests: Fix installation for extended names Jan Tulak
2016-07-15 10:05   ` Eryu Guan
2016-07-11  9:26 ` [PATCH 2/4] fstests: filename handling for extended names in ./check was on a wrong place Jan Tulak
2016-07-13 12:34   ` Eryu Guan
2016-07-14  9:11     ` Jan Tulak
2016-07-14 12:18       ` Eryu Guan
2016-07-14 12:47         ` Jan Tulak
2016-07-11  9:26 ` [PATCH 3/4] xfstests: remove unused variable Jan Tulak
2016-07-11  9:26 ` [PATCH 4/4] xfstests: filename handling - fix early wildcard expansion Jan Tulak
2016-07-13 12:28   ` Eryu Guan [this message]
2016-07-14  8:56     ` Jan Tulak
2016-07-14 12:13       ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160713122859.GV2432@eguan.usersys.redhat.com \
    --to=eguan@redhat.com \
    --cc=david@fromorbit.com \
    --cc=fstests@vger.kernel.org \
    --cc=jtulak@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox