* [PATCH] generic/294: fix _filter_mknod quoting
@ 2016-07-26 20:39 Omar Sandoval
2016-07-27 14:30 ` Eryu Guan
0 siblings, 1 reply; 2+ messages in thread
From: Omar Sandoval @ 2016-07-26 20:39 UTC (permalink / raw)
To: fstests; +Cc: kernel-team
From: Omar Sandoval <osandov@fb.com>
Coreutils 8.4 uses a back tick instead of a single quote when quoting a
file name. That means that _filter_mknod doesn't properly filter the
error message from mknod.
Signed-off-by: Omar Sandoval <osandov@fb.com>
---
common/filter | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/filter b/common/filter
index 8d9f489bea1c..886ab6deae55 100644
--- a/common/filter
+++ b/common/filter
@@ -389,7 +389,7 @@ _filter_od()
# mknod errors print unquoted filenames
_filter_mknod()
{
- sed -e "s/mknod: '\(.*\)': File exists/mknod: \1: File exists/"
+ sed -e "s/mknod: ['\`]\(.*\)': File exists/mknod: \1: File exists/"
}
# make sure this script returns success
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] generic/294: fix _filter_mknod quoting
2016-07-26 20:39 [PATCH] generic/294: fix _filter_mknod quoting Omar Sandoval
@ 2016-07-27 14:30 ` Eryu Guan
0 siblings, 0 replies; 2+ messages in thread
From: Eryu Guan @ 2016-07-27 14:30 UTC (permalink / raw)
To: Omar Sandoval; +Cc: fstests, kernel-team
On Tue, Jul 26, 2016 at 01:39:26PM -0700, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> Coreutils 8.4 uses a back tick instead of a single quote when quoting a
> file name. That means that _filter_mknod doesn't properly filter the
> error message from mknod.
>
> Signed-off-by: Omar Sandoval <osandov@fb.com>
This has been fixed by Jan Kara in latest fstests update.
[9b06a9f] generic/294: Filter backquotes from mknod error output
Thanks for the follow up!
Eryu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-27 14:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-26 20:39 [PATCH] generic/294: fix _filter_mknod quoting Omar Sandoval
2016-07-27 14:30 ` Eryu Guan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox