From: Dave Chinner <david@fromorbit.com>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: fstests@vger.kernel.org, darrick.wong@oracle.com
Subject: Re: [PATCH] xfs: fix __populate_check_xfs_dir
Date: Wed, 19 Oct 2016 15:42:41 +1100 [thread overview]
Message-ID: <20161019044241.GJ14023@dastard> (raw)
In-Reply-To: <1476759584-4150-1-git-send-email-yangx.jy@cn.fujitsu.com>
On Tue, Oct 18, 2016 at 10:59:44AM +0800, Xiao Yang wrote:
> We need to remove unused ${SCRATCH_DEV} when calling __populate_check_xfs_dir
> because __populate_check_xfs_dir function has been rewritten by Darrick.
Can you reference the commit that the relevant change was contained
in, please? Darrick has made lots of changes - saying "fix
something after Darrick changed something else" isn't very
meaningful, especially when someone looks at the commit in a few
years time. Instead, try something like this:
----
[PATCH] xfstests: remove the device parameter from __populate_check_xfs_dir
In commit abcdef1234 ("rewrite the frobnozzle"), the need for
callers to pass the device to populate into
__populate_check_xfs_dir() was removed. We can now clean up all the
callers by removing the device parameter."
----
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2016-10-19 4:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 2:59 [PATCH] xfs: fix __populate_check_xfs_dir Xiao Yang
2016-10-18 3:58 ` Darrick J. Wong
2016-10-19 4:42 ` Dave Chinner [this message]
2016-10-19 5:24 ` Xiao Yang
2016-10-19 5:33 ` [PATCH v2] xfs: remove the device parameter from __populate_check_xfs_dir Xiao Yang
2016-10-19 6:04 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019044241.GJ14023@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=yangx.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox