* [PATCH] xfs: fix __populate_check_xfs_dir
@ 2016-10-18 2:59 Xiao Yang
2016-10-18 3:58 ` Darrick J. Wong
2016-10-19 4:42 ` Dave Chinner
0 siblings, 2 replies; 6+ messages in thread
From: Xiao Yang @ 2016-10-18 2:59 UTC (permalink / raw)
To: fstests; +Cc: darrick.wong, Xiao Yang
We need to remove unused ${SCRATCH_DEV} when calling __populate_check_xfs_dir
because __populate_check_xfs_dir function has been rewritten by Darrick.
Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
---
tests/xfs/099 | 2 +-
tests/xfs/100 | 2 +-
tests/xfs/101 | 2 +-
tests/xfs/102 | 2 +-
tests/xfs/105 | 2 +-
tests/xfs/112 | 2 +-
tests/xfs/113 | 2 +-
7 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/tests/xfs/099 b/tests/xfs/099
index ebc02dd..85193ab 100755
--- a/tests/xfs/099
+++ b/tests/xfs/099
@@ -75,7 +75,7 @@ echo "+ check fs"
_scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
echo "+ check dir"
-__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" block
+__populate_check_xfs_dir "${inode}" block
echo "+ corrupt dir"
_scratch_xfs_db -x -c "inode ${inode}" -c 'dblock 0' -c "stack" -c "blocktrash -x 32 -y $((blksz * 8)) -z ${FUZZ_ARGS}" >> $seqres.full
diff --git a/tests/xfs/100 b/tests/xfs/100
index 2412c81..3bfafce 100755
--- a/tests/xfs/100
+++ b/tests/xfs/100
@@ -75,7 +75,7 @@ echo "+ check fs"
_scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
echo "+ check dir"
-__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" leaf
+__populate_check_xfs_dir "${inode}" leaf
echo "+ corrupt dir"
loff=0
diff --git a/tests/xfs/101 b/tests/xfs/101
index 679940f..d3abd19 100755
--- a/tests/xfs/101
+++ b/tests/xfs/101
@@ -75,7 +75,7 @@ echo "+ check fs"
_scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
echo "+ check dir"
-__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" leaf
+__populate_check_xfs_dir "${inode}" leaf
echo "+ corrupt dir"
_scratch_xfs_db -x -c "inode ${inode}" -c "dblock ${leaf_lblk}" -c "stack" -c "blocktrash -x 32 -y $((blksz * 8)) -z ${FUZZ_ARGS}" >> $seqres.full
diff --git a/tests/xfs/102 b/tests/xfs/102
index 8018a9e..cf0d7a6 100755
--- a/tests/xfs/102
+++ b/tests/xfs/102
@@ -75,7 +75,7 @@ echo "+ check fs"
_scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
echo "+ check dir"
-__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" node
+__populate_check_xfs_dir "${inode}" node
echo "+ corrupt dir"
loff=0
diff --git a/tests/xfs/105 b/tests/xfs/105
index 27ee4b3..07ccf00 100755
--- a/tests/xfs/105
+++ b/tests/xfs/105
@@ -75,7 +75,7 @@ echo "+ check fs"
_scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
echo "+ check dir"
-__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" node
+__populate_check_xfs_dir "${inode}" node
echo "+ corrupt dir"
loff="${leaf_lblk}"
diff --git a/tests/xfs/112 b/tests/xfs/112
index c237f03..84f1f1d 100755
--- a/tests/xfs/112
+++ b/tests/xfs/112
@@ -75,7 +75,7 @@ echo "+ check fs"
_scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
echo "+ check dir"
-__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" node
+__populate_check_xfs_dir "${inode}" node
echo "+ corrupt dir"
loff="${node_lblk}"
diff --git a/tests/xfs/113 b/tests/xfs/113
index 6d6e6fd..ec328bc 100755
--- a/tests/xfs/113
+++ b/tests/xfs/113
@@ -75,7 +75,7 @@ echo "+ check fs"
_scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
echo "+ check dir"
-__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" btree
+__populate_check_xfs_dir "${inode}" btree
echo "+ corrupt dir"
loff=0
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] xfs: fix __populate_check_xfs_dir
2016-10-18 2:59 [PATCH] xfs: fix __populate_check_xfs_dir Xiao Yang
@ 2016-10-18 3:58 ` Darrick J. Wong
2016-10-19 4:42 ` Dave Chinner
1 sibling, 0 replies; 6+ messages in thread
From: Darrick J. Wong @ 2016-10-18 3:58 UTC (permalink / raw)
To: Xiao Yang; +Cc: fstests
On Tue, Oct 18, 2016 at 10:59:44AM +0800, Xiao Yang wrote:
> We need to remove unused ${SCRATCH_DEV} when calling __populate_check_xfs_dir
> because __populate_check_xfs_dir function has been rewritten by Darrick.
What a jerk, that guy. ;)
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
(There'll be a lot more going on soon with common/populate once I get
going on the "fuzz every field" tests again.)
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
> tests/xfs/099 | 2 +-
> tests/xfs/100 | 2 +-
> tests/xfs/101 | 2 +-
> tests/xfs/102 | 2 +-
> tests/xfs/105 | 2 +-
> tests/xfs/112 | 2 +-
> tests/xfs/113 | 2 +-
> 7 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/tests/xfs/099 b/tests/xfs/099
> index ebc02dd..85193ab 100755
> --- a/tests/xfs/099
> +++ b/tests/xfs/099
> @@ -75,7 +75,7 @@ echo "+ check fs"
> _scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
>
> echo "+ check dir"
> -__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" block
> +__populate_check_xfs_dir "${inode}" block
>
> echo "+ corrupt dir"
> _scratch_xfs_db -x -c "inode ${inode}" -c 'dblock 0' -c "stack" -c "blocktrash -x 32 -y $((blksz * 8)) -z ${FUZZ_ARGS}" >> $seqres.full
> diff --git a/tests/xfs/100 b/tests/xfs/100
> index 2412c81..3bfafce 100755
> --- a/tests/xfs/100
> +++ b/tests/xfs/100
> @@ -75,7 +75,7 @@ echo "+ check fs"
> _scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
>
> echo "+ check dir"
> -__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" leaf
> +__populate_check_xfs_dir "${inode}" leaf
>
> echo "+ corrupt dir"
> loff=0
> diff --git a/tests/xfs/101 b/tests/xfs/101
> index 679940f..d3abd19 100755
> --- a/tests/xfs/101
> +++ b/tests/xfs/101
> @@ -75,7 +75,7 @@ echo "+ check fs"
> _scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
>
> echo "+ check dir"
> -__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" leaf
> +__populate_check_xfs_dir "${inode}" leaf
>
> echo "+ corrupt dir"
> _scratch_xfs_db -x -c "inode ${inode}" -c "dblock ${leaf_lblk}" -c "stack" -c "blocktrash -x 32 -y $((blksz * 8)) -z ${FUZZ_ARGS}" >> $seqres.full
> diff --git a/tests/xfs/102 b/tests/xfs/102
> index 8018a9e..cf0d7a6 100755
> --- a/tests/xfs/102
> +++ b/tests/xfs/102
> @@ -75,7 +75,7 @@ echo "+ check fs"
> _scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
>
> echo "+ check dir"
> -__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" node
> +__populate_check_xfs_dir "${inode}" node
>
> echo "+ corrupt dir"
> loff=0
> diff --git a/tests/xfs/105 b/tests/xfs/105
> index 27ee4b3..07ccf00 100755
> --- a/tests/xfs/105
> +++ b/tests/xfs/105
> @@ -75,7 +75,7 @@ echo "+ check fs"
> _scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
>
> echo "+ check dir"
> -__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" node
> +__populate_check_xfs_dir "${inode}" node
>
> echo "+ corrupt dir"
> loff="${leaf_lblk}"
> diff --git a/tests/xfs/112 b/tests/xfs/112
> index c237f03..84f1f1d 100755
> --- a/tests/xfs/112
> +++ b/tests/xfs/112
> @@ -75,7 +75,7 @@ echo "+ check fs"
> _scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
>
> echo "+ check dir"
> -__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" node
> +__populate_check_xfs_dir "${inode}" node
>
> echo "+ corrupt dir"
> loff="${node_lblk}"
> diff --git a/tests/xfs/113 b/tests/xfs/113
> index 6d6e6fd..ec328bc 100755
> --- a/tests/xfs/113
> +++ b/tests/xfs/113
> @@ -75,7 +75,7 @@ echo "+ check fs"
> _scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
>
> echo "+ check dir"
> -__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" btree
> +__populate_check_xfs_dir "${inode}" btree
>
> echo "+ corrupt dir"
> loff=0
> --
> 1.8.3.1
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfs: fix __populate_check_xfs_dir
2016-10-18 2:59 [PATCH] xfs: fix __populate_check_xfs_dir Xiao Yang
2016-10-18 3:58 ` Darrick J. Wong
@ 2016-10-19 4:42 ` Dave Chinner
2016-10-19 5:24 ` Xiao Yang
2016-10-19 5:33 ` [PATCH v2] xfs: remove the device parameter from __populate_check_xfs_dir Xiao Yang
1 sibling, 2 replies; 6+ messages in thread
From: Dave Chinner @ 2016-10-19 4:42 UTC (permalink / raw)
To: Xiao Yang; +Cc: fstests, darrick.wong
On Tue, Oct 18, 2016 at 10:59:44AM +0800, Xiao Yang wrote:
> We need to remove unused ${SCRATCH_DEV} when calling __populate_check_xfs_dir
> because __populate_check_xfs_dir function has been rewritten by Darrick.
Can you reference the commit that the relevant change was contained
in, please? Darrick has made lots of changes - saying "fix
something after Darrick changed something else" isn't very
meaningful, especially when someone looks at the commit in a few
years time. Instead, try something like this:
----
[PATCH] xfstests: remove the device parameter from __populate_check_xfs_dir
In commit abcdef1234 ("rewrite the frobnozzle"), the need for
callers to pass the device to populate into
__populate_check_xfs_dir() was removed. We can now clean up all the
callers by removing the device parameter."
----
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfs: fix __populate_check_xfs_dir
2016-10-19 4:42 ` Dave Chinner
@ 2016-10-19 5:24 ` Xiao Yang
2016-10-19 5:33 ` [PATCH v2] xfs: remove the device parameter from __populate_check_xfs_dir Xiao Yang
1 sibling, 0 replies; 6+ messages in thread
From: Xiao Yang @ 2016-10-19 5:24 UTC (permalink / raw)
To: Dave Chinner; +Cc: fstests, darrick.wong
On 2016/10/19 12:42, Dave Chinner wrote:
> On Tue, Oct 18, 2016 at 10:59:44AM +0800, Xiao Yang wrote:
>> We need to remove unused ${SCRATCH_DEV} when calling __populate_check_xfs_dir
>> because __populate_check_xfs_dir function has been rewritten by Darrick.
> Can you reference the commit that the relevant change was contained
> in, please? Darrick has made lots of changes - saying "fix
> something after Darrick changed something else" isn't very
> meaningful, especially when someone looks at the commit in a few
> years time. Instead, try something like this:
>
> ----
> [PATCH] xfstests: remove the device parameter from __populate_check_xfs_dir
>
> In commit abcdef1234 ("rewrite the frobnozzle"), the need for
> callers to pass the device to populate into
> __populate_check_xfs_dir() was removed. We can now clean up all the
> callers by removing the device parameter."
> ----
>
> Cheers,
>
> Dave.
Hi Darrick, Dave
Sorry, it's my fault, I will rewrite this commit.
Thanks,
Xiao Yang
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] xfs: remove the device parameter from __populate_check_xfs_dir
2016-10-19 4:42 ` Dave Chinner
2016-10-19 5:24 ` Xiao Yang
@ 2016-10-19 5:33 ` Xiao Yang
2016-10-19 6:04 ` Darrick J. Wong
1 sibling, 1 reply; 6+ messages in thread
From: Xiao Yang @ 2016-10-19 5:33 UTC (permalink / raw)
To: david; +Cc: fstests, darrick.wong, Xiao Yang
In commit c08ebd092("xfs: fix $XFS_DB_PROG usage"), the need for callers
to pass the device to populate into __populate_check_xfs_dir() was removed.
So we can now clean up all the callers by removing the device parameter.
Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
---
tests/xfs/099 | 2 +-
tests/xfs/100 | 2 +-
tests/xfs/101 | 2 +-
tests/xfs/102 | 2 +-
tests/xfs/105 | 2 +-
tests/xfs/112 | 2 +-
tests/xfs/113 | 2 +-
7 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/tests/xfs/099 b/tests/xfs/099
index ebc02dd..85193ab 100755
--- a/tests/xfs/099
+++ b/tests/xfs/099
@@ -75,7 +75,7 @@ echo "+ check fs"
_scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
echo "+ check dir"
-__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" block
+__populate_check_xfs_dir "${inode}" block
echo "+ corrupt dir"
_scratch_xfs_db -x -c "inode ${inode}" -c 'dblock 0' -c "stack" -c "blocktrash -x 32 -y $((blksz * 8)) -z ${FUZZ_ARGS}" >> $seqres.full
diff --git a/tests/xfs/100 b/tests/xfs/100
index 2412c81..3bfafce 100755
--- a/tests/xfs/100
+++ b/tests/xfs/100
@@ -75,7 +75,7 @@ echo "+ check fs"
_scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
echo "+ check dir"
-__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" leaf
+__populate_check_xfs_dir "${inode}" leaf
echo "+ corrupt dir"
loff=0
diff --git a/tests/xfs/101 b/tests/xfs/101
index 679940f..d3abd19 100755
--- a/tests/xfs/101
+++ b/tests/xfs/101
@@ -75,7 +75,7 @@ echo "+ check fs"
_scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
echo "+ check dir"
-__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" leaf
+__populate_check_xfs_dir "${inode}" leaf
echo "+ corrupt dir"
_scratch_xfs_db -x -c "inode ${inode}" -c "dblock ${leaf_lblk}" -c "stack" -c "blocktrash -x 32 -y $((blksz * 8)) -z ${FUZZ_ARGS}" >> $seqres.full
diff --git a/tests/xfs/102 b/tests/xfs/102
index 8018a9e..cf0d7a6 100755
--- a/tests/xfs/102
+++ b/tests/xfs/102
@@ -75,7 +75,7 @@ echo "+ check fs"
_scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
echo "+ check dir"
-__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" node
+__populate_check_xfs_dir "${inode}" node
echo "+ corrupt dir"
loff=0
diff --git a/tests/xfs/105 b/tests/xfs/105
index 27ee4b3..07ccf00 100755
--- a/tests/xfs/105
+++ b/tests/xfs/105
@@ -75,7 +75,7 @@ echo "+ check fs"
_scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
echo "+ check dir"
-__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" node
+__populate_check_xfs_dir "${inode}" node
echo "+ corrupt dir"
loff="${leaf_lblk}"
diff --git a/tests/xfs/112 b/tests/xfs/112
index c237f03..84f1f1d 100755
--- a/tests/xfs/112
+++ b/tests/xfs/112
@@ -75,7 +75,7 @@ echo "+ check fs"
_scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
echo "+ check dir"
-__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" node
+__populate_check_xfs_dir "${inode}" node
echo "+ corrupt dir"
loff="${node_lblk}"
diff --git a/tests/xfs/113 b/tests/xfs/113
index 6d6e6fd..ec328bc 100755
--- a/tests/xfs/113
+++ b/tests/xfs/113
@@ -75,7 +75,7 @@ echo "+ check fs"
_scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
echo "+ check dir"
-__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" btree
+__populate_check_xfs_dir "${inode}" btree
echo "+ corrupt dir"
loff=0
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] xfs: remove the device parameter from __populate_check_xfs_dir
2016-10-19 5:33 ` [PATCH v2] xfs: remove the device parameter from __populate_check_xfs_dir Xiao Yang
@ 2016-10-19 6:04 ` Darrick J. Wong
0 siblings, 0 replies; 6+ messages in thread
From: Darrick J. Wong @ 2016-10-19 6:04 UTC (permalink / raw)
To: Xiao Yang; +Cc: david, fstests
On Wed, Oct 19, 2016 at 01:33:07PM +0800, Xiao Yang wrote:
> In commit c08ebd092("xfs: fix $XFS_DB_PROG usage"), the need for callers
> to pass the device to populate into __populate_check_xfs_dir() was removed.
> So we can now clean up all the callers by removing the device parameter.
>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> tests/xfs/099 | 2 +-
> tests/xfs/100 | 2 +-
> tests/xfs/101 | 2 +-
> tests/xfs/102 | 2 +-
> tests/xfs/105 | 2 +-
> tests/xfs/112 | 2 +-
> tests/xfs/113 | 2 +-
> 7 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/tests/xfs/099 b/tests/xfs/099
> index ebc02dd..85193ab 100755
> --- a/tests/xfs/099
> +++ b/tests/xfs/099
> @@ -75,7 +75,7 @@ echo "+ check fs"
> _scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
>
> echo "+ check dir"
> -__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" block
> +__populate_check_xfs_dir "${inode}" block
>
> echo "+ corrupt dir"
> _scratch_xfs_db -x -c "inode ${inode}" -c 'dblock 0' -c "stack" -c "blocktrash -x 32 -y $((blksz * 8)) -z ${FUZZ_ARGS}" >> $seqres.full
> diff --git a/tests/xfs/100 b/tests/xfs/100
> index 2412c81..3bfafce 100755
> --- a/tests/xfs/100
> +++ b/tests/xfs/100
> @@ -75,7 +75,7 @@ echo "+ check fs"
> _scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
>
> echo "+ check dir"
> -__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" leaf
> +__populate_check_xfs_dir "${inode}" leaf
>
> echo "+ corrupt dir"
> loff=0
> diff --git a/tests/xfs/101 b/tests/xfs/101
> index 679940f..d3abd19 100755
> --- a/tests/xfs/101
> +++ b/tests/xfs/101
> @@ -75,7 +75,7 @@ echo "+ check fs"
> _scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
>
> echo "+ check dir"
> -__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" leaf
> +__populate_check_xfs_dir "${inode}" leaf
>
> echo "+ corrupt dir"
> _scratch_xfs_db -x -c "inode ${inode}" -c "dblock ${leaf_lblk}" -c "stack" -c "blocktrash -x 32 -y $((blksz * 8)) -z ${FUZZ_ARGS}" >> $seqres.full
> diff --git a/tests/xfs/102 b/tests/xfs/102
> index 8018a9e..cf0d7a6 100755
> --- a/tests/xfs/102
> +++ b/tests/xfs/102
> @@ -75,7 +75,7 @@ echo "+ check fs"
> _scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
>
> echo "+ check dir"
> -__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" node
> +__populate_check_xfs_dir "${inode}" node
>
> echo "+ corrupt dir"
> loff=0
> diff --git a/tests/xfs/105 b/tests/xfs/105
> index 27ee4b3..07ccf00 100755
> --- a/tests/xfs/105
> +++ b/tests/xfs/105
> @@ -75,7 +75,7 @@ echo "+ check fs"
> _scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
>
> echo "+ check dir"
> -__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" node
> +__populate_check_xfs_dir "${inode}" node
>
> echo "+ corrupt dir"
> loff="${leaf_lblk}"
> diff --git a/tests/xfs/112 b/tests/xfs/112
> index c237f03..84f1f1d 100755
> --- a/tests/xfs/112
> +++ b/tests/xfs/112
> @@ -75,7 +75,7 @@ echo "+ check fs"
> _scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
>
> echo "+ check dir"
> -__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" node
> +__populate_check_xfs_dir "${inode}" node
>
> echo "+ corrupt dir"
> loff="${node_lblk}"
> diff --git a/tests/xfs/113 b/tests/xfs/113
> index 6d6e6fd..ec328bc 100755
> --- a/tests/xfs/113
> +++ b/tests/xfs/113
> @@ -75,7 +75,7 @@ echo "+ check fs"
> _scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
>
> echo "+ check dir"
> -__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" btree
> +__populate_check_xfs_dir "${inode}" btree
>
> echo "+ corrupt dir"
> loff=0
> --
> 1.8.3.1
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-19 6:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-18 2:59 [PATCH] xfs: fix __populate_check_xfs_dir Xiao Yang
2016-10-18 3:58 ` Darrick J. Wong
2016-10-19 4:42 ` Dave Chinner
2016-10-19 5:24 ` Xiao Yang
2016-10-19 5:33 ` [PATCH v2] xfs: remove the device parameter from __populate_check_xfs_dir Xiao Yang
2016-10-19 6:04 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox