From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] generic: fix $tmp path in tests
Date: Mon, 14 Nov 2016 10:14:18 +1100 [thread overview]
Message-ID: <20161113231418.GL28922@dastard> (raw)
In-Reply-To: <1478976041-2006-1-git-send-email-eguan@redhat.com>
On Sun, Nov 13, 2016 at 02:40:41AM +0800, Eryu Guan wrote:
> Some tests use "tmp/$$" as $tmp, and this would result in ENOENT
> failure if $tmp is referenced in helpers or tests, because we have
> no "tmp" dir in pwd.
>
> Fix them to use "/tmp/$$" as all other tests do.
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2016-11-13 23:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-12 18:40 [PATCH] generic: fix $tmp path in tests Eryu Guan
2016-11-13 23:14 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161113231418.GL28922@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox