[PATCH] generic: fix $tmp path in tests

[PATCH] generic: fix $tmp path in tests

[Eryu Guan]

Some tests use "tmp/$$" as $tmp, and this would result in ENOENT
failure if $tmp is referenced in helpers or tests, because we have
no "tmp" dir in pwd.

Fix them to use "/tmp/$$" as all other tests do.

Signed-off-by: Eryu Guan <eguan@redhat.com>
---
 tests/generic/018 | 2 +-
 tests/generic/094 | 2 +-
 tests/generic/225 | 2 +-
 tests/generic/249 | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/generic/018 b/tests/generic/018
index e8dbab3..e554861 100755
--- a/tests/generic/018
+++ b/tests/generic/018
@@ -26,7 +26,7 @@ seqres=$RESULT_DIR/$seq
 echo "QA output created by $seq"
 
 here=`pwd`
-tmp=tmp/$$
+tmp=/tmp/$$
 status=1	# failure is the default!
 trap "_cleanup; exit \$status" 0 1 2 3 15
 
diff --git a/tests/generic/094 b/tests/generic/094
index 005de1d..b686a5b 100755
--- a/tests/generic/094
+++ b/tests/generic/094
@@ -26,7 +26,7 @@ seqres=$RESULT_DIR/$seq
 echo "QA output created by $seq"
 
 here=`pwd`
-tmp=tmp/$$
+tmp=/tmp/$$
 status=1  # failure is the default!
 trap "_cleanup; exit \$status" 0 1 2 3 15
 
diff --git a/tests/generic/225 b/tests/generic/225
index 5285e68..544e0be 100755
--- a/tests/generic/225
+++ b/tests/generic/225
@@ -26,7 +26,7 @@ seqres=$RESULT_DIR/$seq
 echo "QA output created by $seq"
 
 here=`pwd`
-tmp=tmp/$$
+tmp=/tmp/$$
 status=1  # failure is the default!
 trap "_cleanup; exit \$status" 0 1 2 3 15
 
diff --git a/tests/generic/249 b/tests/generic/249
index d8b4df4..9b75478 100755
--- a/tests/generic/249
+++ b/tests/generic/249
@@ -26,7 +26,7 @@ seqres=$RESULT_DIR/$seq
 echo "QA output created by $seq"
 
 here=`pwd`
-tmp=tmp/$$
+tmp=/tmp/$$
 status=1  # failure is the default!
 trap "_cleanup; exit \$status" 0 1 2 3 15
 
-- 
2.7.4

Re: [PATCH] generic: fix $tmp path in tests

[Dave Chinner]

On Sun, Nov 13, 2016 at 02:40:41AM +0800, Eryu Guan wrote:
> Some tests use "tmp/$$" as $tmp, and this would result in ENOENT
> failure if $tmp is referenced in helpers or tests, because we have
> no "tmp" dir in pwd.
> 
> Fix them to use "/tmp/$$" as all other tests do.
> 
> Signed-off-by: Eryu Guan <eguan@redhat.com>

looks fine.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com