From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] common: cleanups after common/rc split
Date: Fri, 2 Dec 2016 17:51:28 +1100 [thread overview]
Message-ID: <20161202065128.GJ11750@dastard> (raw)
In-Reply-To: <20161202062533.GJ29149@eguan.usersys.redhat.com>
On Fri, Dec 02, 2016 at 02:25:33PM +0800, Eryu Guan wrote:
> On Fri, Dec 02, 2016 at 11:35:04AM +0800, Eryu Guan wrote:
> ...
> > > > + if [ $ok -eq 0 ]; then
> > > > + echo "*** mount output ***" >>$seqres.full
> > > > + _mount >>$seqres.full
> > > > + echo "*** end mount output" >>$seqres.full
> > > > + elif [ "$type" = "xfs" ]; then
> > > > + _mount_or_remount_rw "$extra_mount_options" $device $mountpoint
>
> I looked at this more and I think that a "ok=$?" is missed here
> (_mount_or_remount_rw return 1 as success), both
> _check_generic_filesystem and _check_btrfs_filesystem do this. So if it
> passes the first $ok check then does this rw mount and sets $ok based on
> the mount result. I'll just add a "ok=$?" here.
Sounds good. :P
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2016-12-02 6:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 4:22 [PATCH] common: cleanups after common/rc split Eryu Guan
2016-12-02 3:29 ` Dave Chinner
2016-12-02 3:35 ` Eryu Guan
2016-12-02 6:25 ` Eryu Guan
2016-12-02 6:51 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161202065128.GJ11750@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox