From: Christoph Hellwig <hch@infradead.org>
To: Zdenek Kabelac <zkabelac@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Dave Chinner <david@fromorbit.com>,
eguan@redhat.com, fstests@vger.kernel.org, dm-devel@redhat.com
Subject: Re: trouble with generic/081
Date: Fri, 16 Dec 2016 00:15:23 -0800 [thread overview]
Message-ID: <20161216081523.GA13847@infradead.org> (raw)
In-Reply-To: <c05b64b6-80d3-655d-db9b-6f49038e53ee@redhat.com>
On Thu, Dec 15, 2016 at 10:16:23AM +0100, Zdenek Kabelac wrote:
> So let me explain the logic behind this 'amazingly stupid' idea.
And that logic doesn't make any sense at all. invibly unmounting
a file system behind the users back is actively harmful, as it is
contradicting the principle of least surprise, and the xfstests mess
is one simple example for it. Add a callback in-kernel to tell the
fs to shut down but NOT unmount and expose the namespace below it,
which the administrator has probably intentionally hid.
Even worse unmount may trigger further writes and with fses not
handling them the fs might now be stuck after being detached from
the namespace without a way for the admin to detect or recover this.
What XFS did on IRIX was to let the volume manager call into the fs
and shut it down. At this point no further writes are possible,
but we do not expose the namespace under the mount point, and the
admin can fix the situation with all the normal tools.
next prev parent reply other threads:[~2016-12-16 8:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 16:43 trouble with generic/081 Christoph Hellwig
2016-12-15 6:29 ` Eryu Guan
2016-12-15 6:36 ` Dave Chinner
2016-12-15 8:42 ` Christoph Hellwig
2016-12-15 9:16 ` Zdenek Kabelac
2016-12-16 8:15 ` Christoph Hellwig [this message]
2017-01-04 23:03 ` Eric Sandeen
2017-01-05 10:35 ` Zdenek Kabelac
2017-01-05 16:26 ` Mike Snitzer
2017-01-05 17:42 ` Zdenek Kabelac
2017-01-05 18:07 ` Mike Snitzer
2017-01-05 18:40 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161216081523.GA13847@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=dm-devel@redhat.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox