* [PATCH] mvtest: change "FSQA Test No." when we renumber tests
@ 2017-01-23 18:52 Darrick J. Wong
2017-01-24 3:20 ` Eryu Guan
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2017-01-23 18:52 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests
We have a number of tests (and submitters) who write tests containing
"FSQA Test No." (as opposed to "FS QA Test No."), so update the mvtest
script to change both forms.
Also fix a sed bug that deletes too many group lines.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
tools/mvtest | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/mvtest b/tools/mvtest
index 20bc23e..572ae14 100755
--- a/tools/mvtest
+++ b/tools/mvtest
@@ -37,14 +37,14 @@ dgroupfile="tests/${dgroup}/group"
git mv "tests/${src}" "tests/${dest}"
git mv "tests/${src}.out" "tests/${dest}.out"
-sed -e "s/^# FS QA Test No. ${sid}$/# FS QA Test No. ${did}/g" -i "tests/${dest}"
+sed -e "s/^# FS[[:space:]]*QA.*Test.*[0-9]\+$/# FS QA Test No. ${did}/g" -i "tests/${dest}"
sed -e "s/^QA output created by ${sid}$/QA output created by ${did}/g" -i "tests/${dest}.out"
sed -e "s/test-${sid}/test-${did}/g" -i "tests/${dest}.out"
grpline="$(grep "^${sid} " "${sgroupfile}")"
newgrpline="$(echo "${grpline}" | sed -e "s/^${sid} /${did} /g")"
-sed -e "/^${sid}.*$/d" -i "${sgroupfile}"
+sed -e "/^${sid} .*$/d" -i "${sgroupfile}"
cp "${dgroupfile}" "${dgroupfile}.new"
append "${dgroupfile}.new" "${newgrpline}"
"${dir}/sort-group" "${dgroupfile}.new"
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mvtest: change "FSQA Test No." when we renumber tests
2017-01-23 18:52 [PATCH] mvtest: change "FSQA Test No." when we renumber tests Darrick J. Wong
@ 2017-01-24 3:20 ` Eryu Guan
0 siblings, 0 replies; 2+ messages in thread
From: Eryu Guan @ 2017-01-24 3:20 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: fstests
On Mon, Jan 23, 2017 at 10:52:24AM -0800, Darrick J. Wong wrote:
> We have a number of tests (and submitters) who write tests containing
> "FSQA Test No." (as opposed to "FS QA Test No."), so update the mvtest
> script to change both forms.
Seems that's another reason to use "./new" to create test template :)
>
> Also fix a sed bug that deletes too many group lines.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Thank you!
Eryu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-24 3:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-23 18:52 [PATCH] mvtest: change "FSQA Test No." when we renumber tests Darrick J. Wong
2017-01-24 3:20 ` Eryu Guan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox