From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH] xfs/348: don't run a fuzzer in the auto group
Date: Fri, 24 Feb 2017 15:09:23 -0800 [thread overview]
Message-ID: <20170224230923.GD22332@birch.djwong.org> (raw)
In-Reply-To: <20170223111444.GD24562@eguan.usersys.redhat.com>
On Thu, Feb 23, 2017 at 07:14:44PM +0800, Eryu Guan wrote:
> On Wed, Feb 22, 2017 at 11:53:33PM -0800, Darrick J. Wong wrote:
> > xfs/348 can cause the kernel to crash by blowing the i_rwsem assert in
> > xfs_destroy_inode on the corrupted inode. Since this is a fuzzer test
> > anyway (it calls xfs_db to break the scratch fs), move it to the fuzzers
> > group.
>
> I agreed fuzzers group should be added, but I'm not sure about removing
> auto group. I think this is a good & targeted regression test that
> excrises the code path that patch "xfs: sanity check directory inode
> di_size" fixed.
>
> And further more, IMO shared/005,7 and xfs/133,4 belong to auto (and
> quick) group too, they're all targeted regression test cases.
>
> If you're worried about crashing kernel by running these tests in auto
> group, perhaps we can consider adding them to dangerous group, then run
> check with "./check -g auto -x dangerous". But these bugs are all fixed,
> the tests shouldn't bring any trouble if running on newer kernels :)
Fair enough. :) I'll send a modified patch adding it to fuzzers.
--D
>
> Thanks,
> Eryu
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-02-24 23:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 7:53 [PATCH] xfs/348: don't run a fuzzer in the auto group Darrick J. Wong
2017-02-23 11:14 ` Eryu Guan
2017-02-24 23:09 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170224230923.GD22332@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox