public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org
Subject: Re: [RFC PATCH] check: try to fix the test device if it gets corrupted
Date: Fri, 3 Mar 2017 17:03:32 +0800	[thread overview]
Message-ID: <20170303090332.GP14226@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20170302232050.31125-1-tytso@mit.edu>

On Thu, Mar 02, 2017 at 06:20:50PM -0500, Theodore Ts'o wrote:
> If the test device gets corrupted all subsequent tests will fail.  To
> prevent this from causing all subsequent tests to be useless, try
> repair the file system on TEST_DEV if possible.  We don't need to do
> this with the scratch device since that file system gets recreated
> each time anyway.
> 
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> ---
> 
> This is a quick hack that I needed while debubgging some research
> code[1].  It turns out that when the grad student is up against a
> paper deadline is an, this becomes amazing evolutionary process which
> creates file system modifications which are optimized for running
> postmark and file bench --- and falls over very easily otherwise.  So
> when TEST_DEV is getting corrupted very frequently, it's nice to be
> able to continue running other tests in the quick or auto group.
> 
> So please consider this a proof-concept-patch; would people consider
> it worthwhile to have this in xfstests upstream?

This idea looks reasonable to me, and TEST_DEV is supposed to be aging,
perhaps being currupted & repaired is kind of aging too :)

Thanks,
Eryu

  reply	other threads:[~2017-03-03  9:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-02 23:20 [RFC PATCH] check: try to fix the test device if it gets corrupted Theodore Ts'o
2017-03-03  9:03 ` Eryu Guan [this message]
2017-03-03 17:21   ` Darrick J. Wong
2017-03-03 23:01     ` Theodore Ts'o
2017-03-27  1:48       ` Theodore Ts'o
2017-03-27  8:51         ` Eryu Guan
2017-07-16  1:30           ` Theodore Ts'o
2017-07-17 23:45             ` Darrick J. Wong
2017-07-18  5:05               ` Eryu Guan
2017-07-18 17:30                 ` Theodore Ts'o
2017-07-19  9:40                   ` Eryu Guan
2017-07-19 14:53                     ` Theodore Ts'o
2017-07-19 15:02                       ` Eryu Guan
2017-07-19 16:13                         ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170303090332.GP14226@eguan.usersys.redhat.com \
    --to=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox