[PATCH] xfs/348: update error message when transmogrifying symlink into directory

[PATCH] xfs/348: update error message when transmogrifying symlink into directory

[Darrick J. Wong]

We introduced the inline directory verifier in 4.11 to prevent the
system from trying to use corrupt inline directories.  This has the
effect of changing the error message in one step of the i_mode fuzz
tester, so update the test accordingly.

Note that prior to the existence of the verifier, this test would
occasionally result in memory corruption that did not become evident
until later.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 tests/xfs/348.out |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/xfs/348.out b/tests/xfs/348.out
index 805d530..f4a7a71 100644
--- a/tests/xfs/348.out
+++ b/tests/xfs/348.out
@@ -110,7 +110,7 @@ would have junked entry "FIFO" in directory PARENT_INO
 stat: 'SCRATCH_MNT/test/DIR' is a directory
 stat: 'SCRATCH_MNT/test/DATA' is a directory
 stat: cannot stat 'SCRATCH_MNT/test/EMPTY': Structure needs cleaning
-stat: 'SCRATCH_MNT/test/SYMLINK' is a directory
+stat: cannot stat 'SCRATCH_MNT/test/SYMLINK': Structure needs cleaning
 stat: cannot stat 'SCRATCH_MNT/test/CHRDEV': Structure needs cleaning
 stat: cannot stat 'SCRATCH_MNT/test/BLKDEV': Structure needs cleaning
 stat: cannot stat 'SCRATCH_MNT/test/FIFO': Structure needs cleaning

Re: [PATCH] xfs/348: update error message when transmogrifying symlink into directory

[Christoph Hellwig]

On Thu, Apr 13, 2017 at 08:39:43AM -0700, Darrick J. Wong wrote:
> We introduced the inline directory verifier in 4.11 to prevent the
> system from trying to use corrupt inline directories.  This has the
> effect of changing the error message in one step of the i_mode fuzz
> tester, so update the test accordingly.
> 
> Note that prior to the existence of the verifier, this test would
> occasionally result in memory corruption that did not become evident
> until later.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>