FS/XFS testing framework
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers3@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: [PATCH] kvm-xfstests: unmount /results before shutting down
Date: Mon,  1 May 2017 10:04:20 -0700	[thread overview]
Message-ID: <20170501170420.94456-1-ebiggers3@gmail.com> (raw)

From: Eric Biggers <ebiggers@google.com>

kvm-xfstests shuts down the VM with 'poweroff -f', which with old
versions of systemd's 'poweroff' command (including the version included
in Debian Jessie) does not call sync().  This could cause data written
to the /results filesystem to be lost.  Work around this by unmounting
/results before shutting down.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot b/kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot
index 2eb3a2b..cd01ffd 100755
--- a/kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot
+++ b/kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot
@@ -92,6 +92,7 @@ then
 	/bin/rm -f /run/gce-finalize-wait
     else
 	/root/runtests.sh
+	umount /results
 	poweroff -f > /dev/null 2>&1
     fi
 else
-- 
2.13.0.rc0.306.g87b477812d-goog


             reply	other threads:[~2017-05-01 17:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-01 17:04 Eric Biggers [this message]
2017-05-02  4:42 ` [PATCH] kvm-xfstests: unmount /results before shutting down Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170501170420.94456-1-ebiggers3@gmail.com \
    --to=ebiggers3@gmail.com \
    --cc=ebiggers@google.com \
    --cc=fstests@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox