* [PATCH] kvm-xfstests: unmount /results before shutting down
@ 2017-05-01 17:04 Eric Biggers
2017-05-02 4:42 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Eric Biggers @ 2017-05-01 17:04 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: fstests, Eric Biggers
From: Eric Biggers <ebiggers@google.com>
kvm-xfstests shuts down the VM with 'poweroff -f', which with old
versions of systemd's 'poweroff' command (including the version included
in Debian Jessie) does not call sync(). This could cause data written
to the /results filesystem to be lost. Work around this by unmounting
/results before shutting down.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot | 1 +
1 file changed, 1 insertion(+)
diff --git a/kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot b/kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot
index 2eb3a2b..cd01ffd 100755
--- a/kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot
+++ b/kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot
@@ -92,6 +92,7 @@ then
/bin/rm -f /run/gce-finalize-wait
else
/root/runtests.sh
+ umount /results
poweroff -f > /dev/null 2>&1
fi
else
--
2.13.0.rc0.306.g87b477812d-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] kvm-xfstests: unmount /results before shutting down
2017-05-01 17:04 [PATCH] kvm-xfstests: unmount /results before shutting down Eric Biggers
@ 2017-05-02 4:42 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2017-05-02 4:42 UTC (permalink / raw)
To: Eric Biggers; +Cc: fstests, Eric Biggers
On Mon, May 01, 2017 at 10:04:20AM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> kvm-xfstests shuts down the VM with 'poweroff -f', which with old
> versions of systemd's 'poweroff' command (including the version included
> in Debian Jessie) does not call sync(). This could cause data written
> to the /results filesystem to be lost. Work around this by unmounting
> /results before shutting down.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-02 4:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-01 17:04 [PATCH] kvm-xfstests: unmount /results before shutting down Eric Biggers
2017-05-02 4:42 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox