* generic/401: Test mountpoint not subdir for filetype support
@ 2017-06-23 15:58 Eric Sandeen
2017-06-23 16:12 ` [PATCH] " Eric Sandeen
0 siblings, 1 reply; 4+ messages in thread
From: Eric Sandeen @ 2017-06-23 15:58 UTC (permalink / raw)
To: fstests
With pending changes for xfs_info/xfs_growfs, the tool
now requires an actual mount point to work properly.
Change this test to test $SCRATCH_MNT not the subdir
beneath it.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/tests/generic/401 b/tests/generic/401
index 04bd1a5..74f2bea 100755
--- a/tests/generic/401
+++ b/tests/generic/401
@@ -79,7 +79,7 @@ mknod $testdir/p p
src/t_dir_type $testdir d | grep -F '.' | sort
# Test that either all file types are unknown or all are correct
-if _supports_filetype $testdir; then
+if _supports_filetype $SCRATCH_MNT; then
# print real file types
src/t_dir_type $testdir | grep -vF '.' | sort
else
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] generic/401: Test mountpoint not subdir for filetype support
2017-06-23 15:58 generic/401: Test mountpoint not subdir for filetype support Eric Sandeen
@ 2017-06-23 16:12 ` Eric Sandeen
2017-06-23 17:20 ` Bill O'Donnell
2017-06-26 3:59 ` Eryu Guan
0 siblings, 2 replies; 4+ messages in thread
From: Eric Sandeen @ 2017-06-23 16:12 UTC (permalink / raw)
To: Eric Sandeen, fstests
With pending changes for xfs_info/xfs_growfs, the tool
now requires an actual mount point to work properly.
Change this test to test $SCRATCH_MNT not the subdir
beneath it.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
Sorry, forgot [PATCH], adding to make sure Eryu sees it.
diff --git a/tests/generic/401 b/tests/generic/401
index 04bd1a5..74f2bea 100755
--- a/tests/generic/401
+++ b/tests/generic/401
@@ -79,7 +79,7 @@ mknod $testdir/p p
src/t_dir_type $testdir d | grep -F '.' | sort
# Test that either all file types are unknown or all are correct
-if _supports_filetype $testdir; then
+if _supports_filetype $SCRATCH_MNT; then
# print real file types
src/t_dir_type $testdir | grep -vF '.' | sort
else
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] generic/401: Test mountpoint not subdir for filetype support
2017-06-23 16:12 ` [PATCH] " Eric Sandeen
@ 2017-06-23 17:20 ` Bill O'Donnell
2017-06-26 3:59 ` Eryu Guan
1 sibling, 0 replies; 4+ messages in thread
From: Bill O'Donnell @ 2017-06-23 17:20 UTC (permalink / raw)
To: Eric Sandeen; +Cc: Eric Sandeen, fstests
On Fri, Jun 23, 2017 at 11:12:41AM -0500, Eric Sandeen wrote:
> With pending changes for xfs_info/xfs_growfs, the tool
> now requires an actual mount point to work properly.
>
> Change this test to test $SCRATCH_MNT not the subdir
> beneath it.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
> ---
>
> Sorry, forgot [PATCH], adding to make sure Eryu sees it.
>
> diff --git a/tests/generic/401 b/tests/generic/401
> index 04bd1a5..74f2bea 100755
> --- a/tests/generic/401
> +++ b/tests/generic/401
> @@ -79,7 +79,7 @@ mknod $testdir/p p
> src/t_dir_type $testdir d | grep -F '.' | sort
>
> # Test that either all file types are unknown or all are correct
> -if _supports_filetype $testdir; then
> +if _supports_filetype $SCRATCH_MNT; then
> # print real file types
> src/t_dir_type $testdir | grep -vF '.' | sort
> else
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] generic/401: Test mountpoint not subdir for filetype support
2017-06-23 16:12 ` [PATCH] " Eric Sandeen
2017-06-23 17:20 ` Bill O'Donnell
@ 2017-06-26 3:59 ` Eryu Guan
1 sibling, 0 replies; 4+ messages in thread
From: Eryu Guan @ 2017-06-26 3:59 UTC (permalink / raw)
To: Eric Sandeen; +Cc: Eric Sandeen, fstests
On Fri, Jun 23, 2017 at 11:12:41AM -0500, Eric Sandeen wrote:
> With pending changes for xfs_info/xfs_growfs, the tool
> now requires an actual mount point to work properly.
>
> Change this test to test $SCRATCH_MNT not the subdir
> beneath it.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> Sorry, forgot [PATCH], adding to make sure Eryu sees it.
Thanks! Saw it :)
Eryu
>
> diff --git a/tests/generic/401 b/tests/generic/401
> index 04bd1a5..74f2bea 100755
> --- a/tests/generic/401
> +++ b/tests/generic/401
> @@ -79,7 +79,7 @@ mknod $testdir/p p
> src/t_dir_type $testdir d | grep -F '.' | sort
>
> # Test that either all file types are unknown or all are correct
> -if _supports_filetype $testdir; then
> +if _supports_filetype $SCRATCH_MNT; then
> # print real file types
> src/t_dir_type $testdir | grep -vF '.' | sort
> else
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-26 3:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-23 15:58 generic/401: Test mountpoint not subdir for filetype support Eric Sandeen
2017-06-23 16:12 ` [PATCH] " Eric Sandeen
2017-06-23 17:20 ` Bill O'Donnell
2017-06-26 3:59 ` Eryu Guan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox