From: Luis Henriques <lhenriques@suse.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org,
Anna Schumaker <Anna.Schumaker@Netapp.com>,
Luis Henriques <lhenriques@suse.com>
Subject: [PATCH 2/2 v2] common/rc: handle xfs_io copy_range when copy_file_range syscall isn't available
Date: Wed, 28 Jun 2017 12:20:51 +0100 [thread overview]
Message-ID: <20170628112051.9164-1-lhenriques@suse.com> (raw)
In-Reply-To: <20170628075008.GE23360@eguan.usersys.redhat.com>
_require_xfs_io_command() isn't handling the case where the copy_file_range
syscall isn't available. To fix this simply check the error returned by
xfs_io.
Signed-off-by: Luis Henriques <lhenriques@suse.com>
---
Changes since v1:
- dropped check that worked around an xfs_io bug.
common/rc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/common/rc b/common/rc
index 2972f89e9527..57d596cd4f2e 100644
--- a/common/rc
+++ b/common/rc
@@ -2195,6 +2195,8 @@ _require_xfs_io_command()
_notrun "xfs_io $command failed (old kernel/wrong fs/bad args?)"
echo $testio | grep -q "foreign file active" && \
_notrun "xfs_io $command not supported on $FSTYP"
+ echo $testio | egrep -q "Function not implemented" && \
+ _notrun "xfs_io $command support is missing (missing syscall?)"
if [ -n "$param" -a $param_checked -eq 0 ]; then
$XFS_IO_PROG -c "help $command" | grep -q "^ $param --" || \
next prev parent reply other threads:[~2017-06-28 11:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 16:40 [PATCH 1/2] generic/430: Fix filename in "copy beyond end" test Luis Henriques
2017-06-26 16:40 ` [PATCH 2/2] common/rc: handle xfs_io copy_range when copy_file_range syscall isn't available Luis Henriques
2017-06-27 5:25 ` Eryu Guan
2017-06-27 8:50 ` Luis Henriques
2017-06-28 7:50 ` Eryu Guan
2017-06-28 11:20 ` Luis Henriques [this message]
2017-06-28 14:21 ` [PATCH 1/2] generic/430: Fix filename in "copy beyond end" test David Disseldorp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628112051.9164-1-lhenriques@suse.com \
--to=lhenriques@suse.com \
--cc=Anna.Schumaker@Netapp.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox