From: David Disseldorp <ddiss@suse.de>
To: Luis Henriques <lhenriques@suse.com>
Cc: fstests@vger.kernel.org, Anna Schumaker <Anna.Schumaker@Netapp.com>
Subject: Re: [PATCH 1/2] generic/430: Fix filename in "copy beyond end" test
Date: Wed, 28 Jun 2017 16:21:59 +0200 [thread overview]
Message-ID: <20170628162159.19813961@suse.de> (raw)
In-Reply-To: <20170626164053.7634-1-lhenriques@suse.com>
On Mon, 26 Jun 2017 17:40:52 +0100, Luis Henriques wrote:
> The cmp command was using the wrong file to perform the comparison. Use
> $testdir/beyond instead of $testdir/end.
>
> Signed-off-by: Luis Henriques <lhenriques@suse.com>
This looks correct to me.
Reviewed-by: David Disseldorp <ddiss@suse.de>
prev parent reply other threads:[~2017-06-28 14:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 16:40 [PATCH 1/2] generic/430: Fix filename in "copy beyond end" test Luis Henriques
2017-06-26 16:40 ` [PATCH 2/2] common/rc: handle xfs_io copy_range when copy_file_range syscall isn't available Luis Henriques
2017-06-27 5:25 ` Eryu Guan
2017-06-27 8:50 ` Luis Henriques
2017-06-28 7:50 ` Eryu Guan
2017-06-28 11:20 ` [PATCH 2/2 v2] " Luis Henriques
2017-06-28 14:21 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628162159.19813961@suse.de \
--to=ddiss@suse.de \
--cc=Anna.Schumaker@Netapp.com \
--cc=fstests@vger.kernel.org \
--cc=lhenriques@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox