public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers3@gmail.com>
To: fstests@vger.kernel.org
Cc: Brian Foster <bfoster@redhat.com>, Eric Biggers <ebiggers@google.com>
Subject: [PATCH] generic/247: unmount test device, not scratch device
Date: Wed,  5 Jul 2017 13:37:54 -0700	[thread overview]
Message-ID: <20170705203754.92140-1-ebiggers3@gmail.com> (raw)

From: Eric Biggers <ebiggers@google.com>

Commit d55123c080cb ("generic/247: filter out expected XFS warnings for
mixed mmap/direct I/O") made generic/247 start explicitly unmounting the
scratch device.  However, the test doesn't actually use the scratch
device, so it will fail if SCRATCH_DEV is undefined.  Fix it by
unmounting the test device instead.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 tests/generic/247 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/247 b/tests/generic/247
index 509e8808..aac70780 100755
--- a/tests/generic/247
+++ b/tests/generic/247
@@ -82,7 +82,7 @@ echo "Silence is golden."
 
 # unmount and check dmesg, filtering out expected XFS warnings about mixed
 # mmap/dio
-_scratch_unmount
+_test_unmount
 if [ "$FSTYP" == "xfs" ]; then
 	_check_dmesg _filter_xfs_dmesg
 else
-- 
2.13.2.725.g09c95d1e9-goog


             reply	other threads:[~2017-07-05 20:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05 20:37 Eric Biggers [this message]
2017-07-06  2:50 ` [PATCH] generic/247: unmount test device, not scratch device Eryu Guan
2017-07-06  2:54   ` Eric Biggers
2017-07-06  3:10     ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170705203754.92140-1-ebiggers3@gmail.com \
    --to=ebiggers3@gmail.com \
    --cc=bfoster@redhat.com \
    --cc=ebiggers@google.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox