From: Eric Biggers <ebiggers3@gmail.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org, Brian Foster <bfoster@redhat.com>,
Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH] generic/247: unmount test device, not scratch device
Date: Wed, 5 Jul 2017 19:54:28 -0700 [thread overview]
Message-ID: <20170706025428.GA595@zzz.localdomain> (raw)
In-Reply-To: <20170706025059.GW23360@eguan.usersys.redhat.com>
On Thu, Jul 06, 2017 at 10:50:59AM +0800, Eryu Guan wrote:
> On Wed, Jul 05, 2017 at 01:37:54PM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > Commit d55123c080cb ("generic/247: filter out expected XFS warnings for
> > mixed mmap/direct I/O") made generic/247 start explicitly unmounting the
> > scratch device. However, the test doesn't actually use the scratch
> > device, so it will fail if SCRATCH_DEV is undefined. Fix it by
> > unmounting the test device instead.
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
>
> Thanks for the fix! I found this in my review and I remembered I removed
> the _scratch_unmount and updated the comments accordingly at commit
> time, but clearly I didn't.
>
It was removed from generic/095 (maybe by accident?) but not generic/247.
Perhaps it needs to be added back to generic/095?
Eric
next prev parent reply other threads:[~2017-07-06 2:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 20:37 [PATCH] generic/247: unmount test device, not scratch device Eric Biggers
2017-07-06 2:50 ` Eryu Guan
2017-07-06 2:54 ` Eric Biggers [this message]
2017-07-06 3:10 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706025428.GA595@zzz.localdomain \
--to=ebiggers3@gmail.com \
--cc=bfoster@redhat.com \
--cc=ebiggers@google.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox