From: "Bill O'Donnell" <billodo@redhat.com>
To: fstests@vger.kernel.org
Cc: eguan@redhat.com
Subject: [PATCH] xfs/424: test xfs_db to ensure sector size taken into account with new type
Date: Wed, 12 Jul 2017 13:31:12 -0500 [thread overview]
Message-ID: <20170712183112.5255-1-billodo@redhat.com> (raw)
xfs_db should take sector size into account when setting type.
If sector size ignored, a false crc error can occur due to
the new size not being picked up when type gets set. This test
checks for that false crc error.
Signed-off-by: Bill O'Donnell <billodo@redhat.com>
---
tests/xfs/424 | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
tests/xfs/424.out | 5 ++++
tests/xfs/group | 1 +
3 files changed, 78 insertions(+)
create mode 100755 tests/xfs/424
create mode 100644 tests/xfs/424.out
diff --git a/tests/xfs/424 b/tests/xfs/424
new file mode 100755
index 00000000..12945678
--- /dev/null
+++ b/tests/xfs/424
@@ -0,0 +1,72 @@
+#! /bin/bash
+# FS QA Test 424
+#
+# xfs_db should take sector size into account when setting type.
+# If sector size ignored, a false crc error can occur due to
+# the new size not being picked up when type is set. This test
+# checks for that false crc error.
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2017 Red Hat, Inc. All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1 # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+ cd /
+ rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# remove previous $seqres.full before test
+rm -f $seqres.full
+
+# real QA test starts here
+_scratch_unmount >> $seqres.full 2>&1
+
+# for different sector sizes, ensure no CRC errors are falsely reported
+$MKFS_PROG -t xfs -f -s size=512 $SCRATCH_DEV > /dev/null
+$XFS_DB_PROG -c "agi 0" -c "daddr" -c "daddr 42" -c "daddr 2" -c "type agi" $SCRATCH_DEV
+
+$MKFS_PROG -t xfs -f -s size=1024 $SCRATCH_DEV > /dev/null
+$XFS_DB_PROG -c "agi 0" -c "daddr" -c "daddr 42" -c "daddr 4" -c "type agi" $SCRATCH_DEV
+
+$MKFS_PROG -t xfs -f -s size=2048 $SCRATCH_DEV > /dev/null
+$XFS_DB_PROG -c "agi 0" -c "daddr" -c "daddr 42" -c "daddr 8" -c "type agi" $SCRATCH_DEV
+
+$MKFS_PROG -t xfs -f -s size=4096 $SCRATCH_DEV > /dev/null
+$XFS_DB_PROG -c "agi 0" -c "daddr" -c "daddr 42" -c "daddr 16" -c "type agi" $SCRATCH_DEV
+
+# Modify as appropriate.
+_supported_fs generic
+_supported_os Linux
+_require_test
+
+# success, all done
+status=0
+exit
diff --git a/tests/xfs/424.out b/tests/xfs/424.out
new file mode 100644
index 00000000..ff12d9d0
--- /dev/null
+++ b/tests/xfs/424.out
@@ -0,0 +1,5 @@
+QA output created by 424
+current daddr is 2
+current daddr is 4
+current daddr is 8
+current daddr is 16
diff --git a/tests/xfs/group b/tests/xfs/group
index ffdb0615..75c8280c 100644
--- a/tests/xfs/group
+++ b/tests/xfs/group
@@ -421,3 +421,4 @@
421 auto quick clone dedupe
422 dangerous_scrub dangerous_online_repair
423 dangerous_scrub
+424 auto quick db
--
2.13.0
next reply other threads:[~2017-07-12 18:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 18:31 Bill O'Donnell [this message]
2017-07-12 19:02 ` [PATCH] xfs/424: test xfs_db to ensure sector size taken into account with new type Eric Sandeen
2017-07-14 14:27 ` [PATCH] xfs/424: test xfs_db to ensure type " Bill O'Donnell
2017-07-14 15:42 ` Eric Sandeen
2017-07-14 16:47 ` Bill O'Donnell
2017-07-14 19:01 ` Eric Sandeen
2017-07-14 19:11 ` Bill O'Donnell
2017-07-14 19:58 ` Bill O'Donnell
2017-07-14 21:43 ` Eric Sandeen
2017-07-14 17:39 ` Darrick J. Wong
2017-07-17 18:53 ` [PATCH v3] " Bill O'Donnell
2017-07-17 19:41 ` Eric Sandeen
2017-07-17 19:48 ` Bill O'Donnell
2017-07-17 20:23 ` Eric Sandeen
2017-07-17 22:09 ` [PATCH v4] " Bill O'Donnell
2017-07-20 4:08 ` Eryu Guan
2017-07-21 14:53 ` [PATCH v5] " Bill O'Donnell
2017-07-24 11:54 ` Eryu Guan
2017-07-24 15:00 ` Bill O'Donnell
2017-07-24 15:07 ` [PATCH v6] " Bill O'Donnell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170712183112.5255-1-billodo@redhat.com \
--to=billodo@redhat.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox