[xfstests PATCH] common/rc: support jfs in _scratch_mkfs_sized

[xfstests PATCH] common/rc: support jfs in _scratch_mkfs_sized

[Ernesto A. Fernández]

Add support for jfs in _scratch_mkfs_sized. Fix the block size in 4096,
which seems to be the only option in jfs_mkfs.

Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com>
---
This change in common/rc is different from the one sent as part of
generic/447, which was not working as intended. I will soon send a revision
of that patch as well.

 common/rc | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/common/rc b/common/rc
index b505365..5cb6b0c 100644
--- a/common/rc
+++ b/common/rc
@@ -1023,6 +1023,8 @@ _scratch_mkfs_sized()
     ext2|ext3|ext4|ext4dev|udf|btrfs|reiser4|ocfs2)
 	def_blksz=`echo $MKFS_OPTIONS| sed -rn 's/.*-b ?+([0-9]+).*/\1/p'`
 	;;
+    jfs)
+	def_blksz=4096
     esac
 
     [ -n "$def_blksz" ] && blocksize=$def_blksz
@@ -1068,6 +1070,9 @@ _scratch_mkfs_sized()
 	(( fssize <= 100 * 1024 * 1024 )) && mixed_opt='--mixed'
 	$MKFS_BTRFS_PROG $MKFS_OPTIONS $mixed_opt -b $fssize $SCRATCH_DEV
 	;;
+    jfs)
+	${MKFS_PROG}.$FSTYP $MKFS_OPTIONS $SCRATCH_DEV $blocks
+	;;
     reiser4)
 	# mkfs.resier4 requires size in KB as input for creating filesystem
 	$MKFS_REISER4_PROG $MKFS_OPTIONS -y -b $blocksize $SCRATCH_DEV \
-- 
2.1.4

[xfstests PATCH v2] common/rc: support jfs in _scratch_mkfs_sized

[Ernesto A. Fernández]

Add support for jfs in _scratch_mkfs_sized. Fix the block size in 4096,
which seems to be the only option in jfs_mkfs.

Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com>
---
I'm sorry, it seems I dropped a double semicolon. It worked the same of course,
but better to fix it.

 common/rc | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/common/rc b/common/rc
index fa1314c..c537ab4 100644
--- a/common/rc
+++ b/common/rc
@@ -1023,6 +1023,9 @@ _scratch_mkfs_sized()
     ext2|ext3|ext4|ext4dev|udf|btrfs|reiser4|ocfs2)
 	def_blksz=`echo $MKFS_OPTIONS| sed -rn 's/.*-b ?+([0-9]+).*/\1/p'`
 	;;
+    jfs)
+	def_blksz=4096
+	;;
     esac
 
     [ -n "$def_blksz" ] && blocksize=$def_blksz
@@ -1068,6 +1071,9 @@ _scratch_mkfs_sized()
 	(( fssize <= 100 * 1024 * 1024 )) && mixed_opt='--mixed'
 	$MKFS_BTRFS_PROG $MKFS_OPTIONS $mixed_opt -b $fssize $SCRATCH_DEV
 	;;
+    jfs)
+	${MKFS_PROG}.$FSTYP $MKFS_OPTIONS $SCRATCH_DEV $blocks
+	;;
     reiser4)
 	# mkfs.resier4 requires size in KB as input for creating filesystem
 	$MKFS_REISER4_PROG $MKFS_OPTIONS -y -b $blocksize $SCRATCH_DEV \
-- 
2.1.4

Re: [xfstests PATCH v2] common/rc: support jfs in _scratch_mkfs_sized

[Eryu Guan]

On Tue, Jul 18, 2017 at 10:37:10PM -0300, Ernesto A. Fernández wrote:
> Add support for jfs in _scratch_mkfs_sized. Fix the block size in 4096,
> which seems to be the only option in jfs_mkfs.
> 
> Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com>
> ---
> I'm sorry, it seems I dropped a double semicolon. It worked the same of course,
> but better to fix it.

Thanks for the update! I didn't catch it in my review either..

Eryu

> 
>  common/rc | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/common/rc b/common/rc
> index fa1314c..c537ab4 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -1023,6 +1023,9 @@ _scratch_mkfs_sized()
>      ext2|ext3|ext4|ext4dev|udf|btrfs|reiser4|ocfs2)
>  	def_blksz=`echo $MKFS_OPTIONS| sed -rn 's/.*-b ?+([0-9]+).*/\1/p'`
>  	;;
> +    jfs)
> +	def_blksz=4096
> +	;;
>      esac
>  
>      [ -n "$def_blksz" ] && blocksize=$def_blksz
> @@ -1068,6 +1071,9 @@ _scratch_mkfs_sized()
>  	(( fssize <= 100 * 1024 * 1024 )) && mixed_opt='--mixed'
>  	$MKFS_BTRFS_PROG $MKFS_OPTIONS $mixed_opt -b $fssize $SCRATCH_DEV
>  	;;
> +    jfs)
> +	${MKFS_PROG}.$FSTYP $MKFS_OPTIONS $SCRATCH_DEV $blocks
> +	;;
>      reiser4)
>  	# mkfs.resier4 requires size in KB as input for creating filesystem
>  	$MKFS_REISER4_PROG $MKFS_OPTIONS -y -b $blocksize $SCRATCH_DEV \
> -- 
> 2.1.4
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html