From: "Ernesto A. Fernández" <ernesto.mnd.fernandez@gmail.com>
To: fstests@vger.kernel.org
Cc: "Eryu Guan" <eguan@redhat.com>,
"Ernesto A. Fernández" <ernesto.mnd.fernandez@gmail.com>,
"Christoph Hellwig" <hch@infradead.org>
Subject: [xfstests PATCH] common/attr: fix check for _require_attrs()
Date: Wed, 19 Jul 2017 01:06:35 -0300 [thread overview]
Message-ID: <20170719040632.GA6712@debian.home> (raw)
As of now xfstests decides if a filesystem supports attributes by trying
to write one to the mount point. For some reason this fails on reiserfs,
making it impossible to run tests that _require_attrs.
Fix this by checking against $TEST_DIR/syscalltest instead of $TEST_DIR.
This is probably what was intended, since the syscalltest file is touched
right before running attr. It is also consistent with how the check for
acl support is done.
Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com>
---
common/attr | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/attr b/common/attr
index c840ce4..21ebbcd 100644
--- a/common/attr
+++ b/common/attr
@@ -217,7 +217,7 @@ _require_attrs()
# stored on disk.
#
touch $TEST_DIR/syscalltest
- attr -s "user.xfstests" -V "attr" $TEST_DIR > $TEST_DIR/syscalltest.out 2>&1
+ attr -s "user.xfstests" -V "attr" $TEST_DIR/syscalltest > $TEST_DIR/syscalltest.out 2>&1
cat $TEST_DIR/syscalltest.out >> $seqres.full
if grep -q 'Function not implemented' $TEST_DIR/syscalltest.out; then
--
2.1.4
reply other threads:[~2017-07-19 4:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170719040632.GA6712@debian.home \
--to=ernesto.mnd.fernandez@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox