* [xfstests PATCH] common/attr: fix check for _require_attrs()
@ 2017-07-19 4:06 Ernesto A. Fernández
0 siblings, 0 replies; only message in thread
From: Ernesto A. Fernández @ 2017-07-19 4:06 UTC (permalink / raw)
To: fstests; +Cc: Eryu Guan, Ernesto A. Fernández, Christoph Hellwig
As of now xfstests decides if a filesystem supports attributes by trying
to write one to the mount point. For some reason this fails on reiserfs,
making it impossible to run tests that _require_attrs.
Fix this by checking against $TEST_DIR/syscalltest instead of $TEST_DIR.
This is probably what was intended, since the syscalltest file is touched
right before running attr. It is also consistent with how the check for
acl support is done.
Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com>
---
common/attr | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/attr b/common/attr
index c840ce4..21ebbcd 100644
--- a/common/attr
+++ b/common/attr
@@ -217,7 +217,7 @@ _require_attrs()
# stored on disk.
#
touch $TEST_DIR/syscalltest
- attr -s "user.xfstests" -V "attr" $TEST_DIR > $TEST_DIR/syscalltest.out 2>&1
+ attr -s "user.xfstests" -V "attr" $TEST_DIR/syscalltest > $TEST_DIR/syscalltest.out 2>&1
cat $TEST_DIR/syscalltest.out >> $seqres.full
if grep -q 'Function not implemented' $TEST_DIR/syscalltest.out; then
--
2.1.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-07-19 4:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-19 4:06 [xfstests PATCH] common/attr: fix check for _require_attrs() Ernesto A. Fernández
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox