public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kvm-xfstests: use aio=native for test drives
@ 2017-09-04 12:15 Amir Goldstein
  2017-09-04 15:55 ` Darrick J. Wong
  2017-09-17 17:08 ` Eric Biggers
  0 siblings, 2 replies; 5+ messages in thread
From: Amir Goldstein @ 2017-09-04 12:15 UTC (permalink / raw)
  To: Theodore Ts'o; +Cc: Eryu Guan, Josef Bacik, fstests

Lost IOs have been observed with the default aio=threads with
QEMU 2.5.0 when running crash consistency tests.
The issue has not been observed with QEMU 2.9.0.
Native AIO is probably better for our goal which is test proofing
production systems.

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---

Ted,

Not sure you have been following the crash consistency tests threads.

Anyway, I ran into an issue of sucessfuly completed bio's that
did not make it to storage device when running in kvm-xfstests.

Josef reported that he did not observe the issue with newer QEMU
and the issue is gone with aio=native on my version of QEMU.

Crash consistency tests still can't run properly on kvm-xfstests
without this fix to kernel:
https://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next.git/commit/?h=dm-log-writes-fixes&id=08c7d64773091c7d2e0147da7064aa4dc297629d
After the fix is merged I will post a patch to enable running
dm-log-write tests in kvm-xfstest.

Mean while, the change to aio=native seems like a good move
anyway and if I observed a bio black hole in one test, who's to say
they don't exist for other tests as well.

Amir.


 kvm-xfstests/kvm-xfstests | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/kvm-xfstests/kvm-xfstests b/kvm-xfstests/kvm-xfstests
index 305e2f5..98bd76a 100755
--- a/kvm-xfstests/kvm-xfstests
+++ b/kvm-xfstests/kvm-xfstests
@@ -101,15 +101,22 @@ chmod 400 "$VDH"
 
 mkdir -p /tmp/kvm-xfstests-$USER
 
+# Lost IOs have been observed with the default aio=threads with
+# QEMU 2.5.0 when running crash consistency tests.
+# The issue has not been observed with QEMU 2.9.0.
+# Native AIO is probably better for our goal which is test proofing
+# production systems.
+AIO=",aio=native"
+
 $NO_ACTION $IONICE $QEMU -boot order=c $NET \
 	-machine type=pc,accel=kvm:tcg \
 	-drive file=$ROOT_FS,if=virtio$SNAPSHOT \
-	-drive file=$VDB,cache=none,if=virtio,format=raw \
-	-drive file=$VDC,cache=none,if=virtio,format=raw \
-	-drive file=$VDD,cache=none,if=virtio,format=raw \
-	-drive file=$VDE,cache=none,if=virtio,format=raw \
-	-drive file=$VDF,cache=none,if=virtio,format=raw \
-	-drive file=$VDG,cache=none,if=virtio,format=raw \
+	-drive file=$VDB,cache=none,if=virtio,format=raw$AIO \
+	-drive file=$VDC,cache=none,if=virtio,format=raw$AIO \
+	-drive file=$VDD,cache=none,if=virtio,format=raw$AIO \
+	-drive file=$VDE,cache=none,if=virtio,format=raw$AIO \
+	-drive file=$VDF,cache=none,if=virtio,format=raw$AIO \
+	-drive file=$VDG,cache=none,if=virtio,format=raw$AIO \
 	-drive file=$VDH,cache=unsafe,readonly,if=virtio \
 	-vga none -nographic -smp $NR_CPU -m $MEM \
 	-fsdev local,id=v_tmp,path=/tmp/kvm-xfstests-$USER,security_model=none \
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-17 17:08 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-04 12:15 [PATCH] kvm-xfstests: use aio=native for test drives Amir Goldstein
2017-09-04 15:55 ` Darrick J. Wong
2017-09-04 17:11   ` Amir Goldstein
2017-09-04 17:32     ` Darrick J. Wong
2017-09-17 17:08 ` Eric Biggers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox