public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
* [xfstests-bld PATCH] gen-image: create /etc/mtab symlink
@ 2017-09-08 23:58 Eric Biggers
  0 siblings, 0 replies; only message in thread
From: Eric Biggers @ 2017-09-08 23:58 UTC (permalink / raw)
  To: Theodore Ts'o; +Cc: fstests, Eric Biggers

From: Eric Biggers <ebiggers@google.com>

Currently the root_fs's are being created with no /etc/mtab file.
/etc/mtab is supposed to be obsolete, but some programs such as mke2fs
still expect it to exist.  On Debian systems, systemd will automatically
symlink /etc/mtab to ../proc/self/mounts as specified by
/usr/lib/tmpfiles.d/debian.conf.  But if the root_fs is used as a chroot
(as android-xfstests does), that does not happen, and as of Debian
Stretch the 'mount' program from util-linux doesn't create /etc/mtab
either.  So until nothing else needs it, just make an /etc/mtab symlink
while creating the root_fs.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 kvm-xfstests/test-appliance/gen-image | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kvm-xfstests/test-appliance/gen-image b/kvm-xfstests/test-appliance/gen-image
index 48cf624..8343294 100755
--- a/kvm-xfstests/test-appliance/gen-image
+++ b/kvm-xfstests/test-appliance/gen-image
@@ -289,6 +289,7 @@ echo "fsgqa:!::" >> $ROOTDIR/etc/gshadow
 mkdir $ROOTDIR/home/fsgqa
 chown 31415:31415 $ROOTDIR/home/fsgqa
 chmod 755 $ROOTDIR/root
+ln -sf ../proc/self/mounts $ROOTDIR/etc/mtab
 fix_symlinks
 
 cp $ROOTDIR/lib/systemd/system/serial-getty@.service \
-- 
2.14.1.581.gf28d330327-goog


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-09-08 23:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-08 23:58 [xfstests-bld PATCH] gen-image: create /etc/mtab symlink Eric Biggers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox