public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: Zorro Lang <zlang@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] generic/252: fix aiocp buffer alignment
Date: Fri, 10 Nov 2017 12:54:44 +0800	[thread overview]
Message-ID: <20171110045444.GA17339@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20171109080901.11214-1-zlang@redhat.com>

On Thu, Nov 09, 2017 at 04:09:01PM +0800, Zorro Lang wrote:
> g/252 fails on 4k hard sector size disk, due to aiocp.c use 512
> bytes alignment by default. So use the '-a' option of aiocp, to
> specify a proper alignment size.
> 
> Signed-off-by: Zorro Lang <zlang@redhat.com>

There're other tests that calls aiocp with direct I/O, I think they can
be fixed too in one patch.

$ grep -H DIRECT `grep aiocp tests/* -rI | cut -d: -f1 | sort | uniq`
tests/generic/252:$AIO_TEST -f DIRECT -b $bufsize $TEST_DIR/moo $testdir/file2 >> $seqres.full
tests/generic/329:$AIO_TEST -f DIRECT -b $bufsize $TEST_DIR/moo $testdir/file2 >> $seqres.full
tests/generic/330:$AIO_TEST -f DIRECT -b $bufsize $TEST_DIR/moo $testdir/file2 >> $seqres.full
tests/xfs/237:$AIO_TEST -f DIRECT -b $bufsize $TEST_DIR/moo $testdir/file2 >> $seqres.full
tests/xfs/239:$AIO_TEST -f DIRECT -b $bufsize $TEST_DIR/moo $testdir/file2 >> $seqres.full

Thanks,
Eryu

  reply	other threads:[~2017-11-10  4:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-09  8:09 [PATCH] generic/252: fix aiocp buffer alignment Zorro Lang
2017-11-10  4:54 ` Eryu Guan [this message]
2017-11-10  6:50   ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171110045444.GA17339@eguan.usersys.redhat.com \
    --to=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox