* [PATCH RESEND] check: source common/rc again if TEST_DEV was recreated
2017-08-02 14:39 [PATCH 1/2] common/config: unset TEST_FS_MOUNT_OPTS across config sections Eryu Guan
@ 2017-10-09 8:16 ` Eryu Guan
0 siblings, 0 replies; 2+ messages in thread
From: Eryu Guan @ 2017-10-09 8:16 UTC (permalink / raw)
To: fstests; +Cc: Eryu Guan
If TEST_DEV is recreated by check, FSTYP derived from TEST_DEV
previously could be changed too and might not reflect the reality.
So source common/rc again with correct FSTYP to get fs-specific
configs, e.g. common/xfs.
For example, using this config-section config file, and run section
ext4 first then xfs, you can see:
our local _scratch_mkfs routine ...
./common/rc: line 825: _scratch_mkfs_xfs: command not found
check: failed to mkfs $SCRATCH_DEV using specified options
local.config:
[default]
RECREATE_TEST_DEV=true
TEST_DEV=/dev/sda5
SCRATCH_DEV=/dev/sda6
TEST_DIR=/mnt/test
SCRATCH_MNT=/mnt/scratch
[ext4]
MKFS_OPTIONS="-b 4096"
FSTYP=ext4
[xfs]
FSTYP=xfs
MKFS_OPTIONS="-f -b size=4k"
Signed-off-by: Eryu Guan <eguan@redhat.com>
---
check | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/check b/check
index f8db3cd6dfab..07586ce463c4 100755
--- a/check
+++ b/check
@@ -555,6 +555,10 @@ for section in $HOST_OPTIONS_SECTIONS; do
status=1
exit
fi
+ # TEST_DEV has been recreated, previous FSTYP derived from
+ # TEST_DEV could be changed, source common/rc again with
+ # correct FSTYP to get FSTYP specific configs, e.g. common/xfs
+ . common/rc
_prepare_test_list
elif [ "$OLD_TEST_FS_MOUNT_OPTS" != "$TEST_FS_MOUNT_OPTS" ]; then
_test_unmount 2> /dev/null
--
2.13.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH RESEND] check: source common/rc again if TEST_DEV was recreated
@ 2017-11-17 7:00 Eryu Guan
0 siblings, 0 replies; 2+ messages in thread
From: Eryu Guan @ 2017-11-17 7:00 UTC (permalink / raw)
To: fstests; +Cc: Eryu Guan
If TEST_DEV is recreated by check, FSTYP derived from TEST_DEV
previously could be changed too and might not reflect the reality.
So source common/rc again with correct FSTYP to get fs-specific
configs, e.g. common/xfs.
For example, using this config-section config file, and run section
ext4 first then xfs, you can see:
our local _scratch_mkfs routine ...
./common/rc: line 825: _scratch_mkfs_xfs: command not found
check: failed to mkfs $SCRATCH_DEV using specified options
local.config:
[default]
RECREATE_TEST_DEV=true
TEST_DEV=/dev/sda5
SCRATCH_DEV=/dev/sda6
TEST_DIR=/mnt/test
SCRATCH_MNT=/mnt/scratch
[ext4]
MKFS_OPTIONS="-b 4096"
FSTYP=ext4
[xfs]
FSTYP=xfs
MKFS_OPTIONS="-f -b size=4k"
Signed-off-by: Eryu Guan <eguan@redhat.com>
---
check | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/check b/check
index f8db3cd6dfab..07586ce463c4 100755
--- a/check
+++ b/check
@@ -555,6 +555,10 @@ for section in $HOST_OPTIONS_SECTIONS; do
status=1
exit
fi
+ # TEST_DEV has been recreated, previous FSTYP derived from
+ # TEST_DEV could be changed, source common/rc again with
+ # correct FSTYP to get FSTYP specific configs, e.g. common/xfs
+ . common/rc
_prepare_test_list
elif [ "$OLD_TEST_FS_MOUNT_OPTS" != "$TEST_FS_MOUNT_OPTS" ]; then
_test_unmount 2> /dev/null
--
2.14.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-17 7:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-17 7:00 [PATCH RESEND] check: source common/rc again if TEST_DEV was recreated Eryu Guan
-- strict thread matches above, loose matches on Subject: below --
2017-08-02 14:39 [PATCH 1/2] common/config: unset TEST_FS_MOUNT_OPTS across config sections Eryu Guan
2017-10-09 8:16 ` [PATCH RESEND] check: source common/rc again if TEST_DEV was recreated Eryu Guan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox