From: "zhangyi (F)" <yi.zhang@huawei.com>
To: linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Cc: miklos@szeredi.hu, amir73il@gmail.com, eguan@redhat.com,
darrick.wong@oracle.com, yi.zhang@huawei.com, miaoxie@huawei.com
Subject: [PATCH v2 17/18] fsck.overlay: not enforce overlayfs is offline in 'no changes' mode
Date: Thu, 14 Dec 2017 14:47:46 +0800 [thread overview]
Message-ID: <20171214064747.20999-18-yi.zhang@huawei.com> (raw)
In-Reply-To: <20171214064747.20999-1-yi.zhang@huawei.com>
Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
---
fsck.c | 4 ++--
mount.c | 14 ++++++--------
2 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/fsck.c b/fsck.c
index 56a5286..d7321fb 100644
--- a/fsck.c
+++ b/fsck.c
@@ -260,7 +260,7 @@ void fsck_status_check(int *val)
int main(int argc, char *argv[])
{
- bool mounted;
+ bool mounted = false;
int err = 0;
int exit_value = 0;
@@ -271,7 +271,7 @@ int main(int argc, char *argv[])
/* Ensure overlay filesystem not mounted */
if ((err = ovl_check_mount(&mounted)))
goto out;
- if (!mounted) {
+ if (mounted && !(flags & FL_OPT_NO)) {
set_st_abort(&status);
goto out;
}
diff --git a/mount.c b/mount.c
index 10970d5..a4bf492 100644
--- a/mount.c
+++ b/mount.c
@@ -280,12 +280,11 @@ static void ovl_scan_mount_exit(struct ovl_mnt_entry *ovl_mnt_entries,
* Note: fsck may modify lower layers, so even match only one directory
* is triggered as mounted.
*/
-int ovl_check_mount(bool *pass)
+int ovl_check_mount(bool *mounted)
{
struct ovl_mnt_entry *ovl_mnt_entries = NULL;
int ovl_mnt_entry_count = 0;
char *mounted_path = NULL;
- bool mounted = false;
int i,j,k;
int ret;
@@ -301,7 +300,7 @@ int ovl_check_mount(bool *pass)
if (!strcmp(lowerdir[k],
ovl_mnt_entries[i].lowerdir[j])) {
mounted_path = lowerdir[k];
- mounted = true;
+ *mounted = true;
goto out;
}
}
@@ -310,23 +309,22 @@ int ovl_check_mount(bool *pass)
/* Check upper */
if (!(strcmp(upperdir, ovl_mnt_entries[i].upperdir))) {
mounted_path = upperdir;
- mounted = true;
+ *mounted = true;
goto out;
}
/* Check worker */
if (workdir[0] != '\0' && !(strcmp(workdir, ovl_mnt_entries[i].workdir))) {
mounted_path = workdir;
- mounted = true;
+ *mounted = true;
goto out;
}
}
out:
ovl_scan_mount_exit(ovl_mnt_entries, ovl_mnt_entry_count);
- if (mounted)
- print_info(_("Dir %s is mounted\n"), mounted_path);
- *pass = !mounted;
+ if (*mounted)
+ print_info(_("WARNING: Dir %s is mounted\n"), mounted_path);
return 0;
}
--
2.9.5
next prev parent reply other threads:[~2017-12-14 6:42 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 6:47 [PATCH v2 00/18] overlay: implement fsck.overlay utility zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 01/18] overlay: implement fsck utility zhangyi (F)
2017-12-14 14:13 ` Miklos Szeredi
2017-12-14 14:33 ` Amir Goldstein
2017-12-14 14:47 ` Miklos Szeredi
2017-12-14 15:03 ` Amir Goldstein
2017-12-14 15:10 ` Miklos Szeredi
2017-12-14 15:18 ` Amir Goldstein
2017-12-14 15:48 ` Miklos Szeredi
2017-12-14 16:03 ` Vivek Goyal
2017-12-14 16:29 ` Amir Goldstein
2017-12-15 14:18 ` Miklos Szeredi
2017-12-15 14:44 ` Amir Goldstein
2017-12-15 16:06 ` Miklos Szeredi
2017-12-15 16:14 ` Miklos Szeredi
2017-12-15 15:16 ` Vivek Goyal
2017-12-15 16:17 ` Miklos Szeredi
2017-12-14 15:21 ` Vivek Goyal
2017-12-14 15:43 ` Amir Goldstein
2017-12-14 16:12 ` Vivek Goyal
2017-12-15 4:18 ` zhangyi (F)
2017-12-15 3:35 ` zhangyi (F)
2017-12-15 7:45 ` Amir Goldstein
2017-12-15 9:13 ` zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 02/18] fsck.overlay: fix uninitialized variable zhangyi (F)
2017-12-14 9:15 ` Amir Goldstein
2017-12-14 6:47 ` [PATCH v2 03/18] fsck.overlay: add -n -p and -y options zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 04/18] fsck.overlay: add path package and split helper zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 05/18] fsck.overlay: convert path parse to use helper function zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 06/18] fsck.overlay: open lowerdirs in advance zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 07/18] fsck.overlay: check lowers use relative path zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 08/18] fsck.overlay: fix spelling mistakes zhangyi (F)
2017-12-14 9:13 ` Amir Goldstein
2017-12-14 6:47 ` [PATCH v2 09/18] fsck.overlay: add counter of checked objects zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 10/18] fsck.overlay: fix verbose flag zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 11/18] fsck.overlay: add ovl_ask_invalid helper zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 12/18] fsck.overlay: remove duplicate redirect xattr in yes mode zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 13/18] fsck.overlay: handle missing case of redirecte directory zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 14/18] fsck.overlay: correct copyright and License zhangyi (F)
2017-12-14 9:09 ` Amir Goldstein
2017-12-14 6:47 ` [PATCH v2 15/18] fsck.overlay: fix word mistake zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 16/18] fsck.overlay: remove test cases zhangyi (F)
2017-12-14 9:11 ` Amir Goldstein
2017-12-14 6:47 ` zhangyi (F) [this message]
2017-12-14 6:47 ` [PATCH v2 18/18] fsck.overlay: use relative path when checking lowers zhangyi (F)
2017-12-14 9:27 ` [PATCH v2 00/18] overlay: implement fsck.overlay utility Amir Goldstein
2017-12-14 10:43 ` zhangyi (F)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214064747.20999-18-yi.zhang@huawei.com \
--to=yi.zhang@huawei.com \
--cc=amir73il@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox