From: "zhangyi (F)" <yi.zhang@huawei.com>
To: linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Cc: miklos@szeredi.hu, amir73il@gmail.com, eguan@redhat.com,
darrick.wong@oracle.com, yi.zhang@huawei.com, miaoxie@huawei.com
Subject: [PATCH v2 18/18] fsck.overlay: use relative path when checking lowers
Date: Thu, 14 Dec 2017 14:47:47 +0800 [thread overview]
Message-ID: <20171214064747.20999-19-yi.zhang@huawei.com> (raw)
In-Reply-To: <20171214064747.20999-1-yi.zhang@huawei.com>
Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
---
README.md | 56 +++++++++++++++++++++++++++++++++-----------------------
1 file changed, 33 insertions(+), 23 deletions(-)
diff --git a/README.md b/README.md
index 8de69cd..1d759b0 100644
--- a/README.md
+++ b/README.md
@@ -20,11 +20,12 @@ Opaque directories
------------------
An opaque directory is a directory with "trusted.overlay.opaque" xattr valued
-"y". There are two legal situations of making opaque directory: 1) create
-directory over whiteout 2) creat directory in merged directory. If an opaque
-directory is found, corresponding matching name in lower layers might exist or
-parent directory might merged, If not, the opaque xattr will be treated as
-invalid and remove.
+"y". There are two legal situations of making opaque directory:
+1) Create directory over whiteout,
+2) Creat directory in merged directory.
+If an opaque directory is found, either corresponding matching name in lower
+layers is exist or parent directory is merged, If not, the opaque xattr will be
+treated as invalid and remove.
Redirect directories
@@ -35,17 +36,21 @@ valued to the path of the original location from the root of the overlay. It
is only used when renaming a directory and "redirect dir" feature is enabled.
If an redirect directory is found, the following must be met:
-1) The directory store in redirect xattr should exist in one of lower layers.
+1) The directory path pointed by redirect xattr should exist in one of lower
+ layers.
2) The origin directory should be redirected only once in one layer, which mean
there is only one redirect xattr point to this origin directory in the
specified layer.
-3) A whiteout or an opaque directory with the same name to origin should exist
- in the same directory as the redirect directory.
+3) A whiteout or an opaque directory or another redirect directory with the
+ same name to origin should exist in the same directory as the redirect
+ directory.
If not, 1) The redirect xattr is invalid and need to remove 2) One of the
-redirect xattr is redundant but not sure which one is, ask user 3) Create a
-whiteout device or set opaque xattr to an existing directory if the parent
-directory was meregd or remove xattr if not.
+redirect xattr is redundant but not sure which one is, ask user by default or
+remove in 'yes' mode 3) Check and fix the missing whiteout or opaque in redierct
+parent directory if there is no another redirected upper directory covering the
+redirect lower target.
+
Usage
=====
@@ -58,14 +63,17 @@ Usage
fsck.overlay [-l lowerdir] [-u upperdir] [-w workdir] [-avhV]
Options:
- -l, --lowerdir=LOWERDIR specify lower directories of overlayfs,
- multiple lower use ':' as separator.
- -u, --upperdir=UPPERDIR specify upper directory of overlayfs
- -w, --workdir=WORKDIR specify work directory of overlayfs
- -a, --auto repair automatically (no questions)
- -v, --verbose print more messages of overlayfs
- -h, --help display this usage of overlayfs
- -V, --version display version information
+ -l, --lowerdir=LOWERDIR specify lower directories of overlayfs,
+ multiple lower use ':' as separator,
+ the leftmost one is the toppest
+ -u, --upperdir=UPPERDIR specify upper directory of overlayfs
+ -w, --workdir=WORKDIR specify work directory of overlayfs
+ -p, automatic repair (no questions)
+ -n, make no changes to the filesystem
+ -y, assume "yes" to all questions
+ -v, --verbose print more messages of overlayfs
+ -h, --help display this usage of overlayfs
+ -V, --version display version information
3. Exit value:
0 No errors
@@ -82,7 +90,9 @@ Todo
1. Overlay filesystem mounted check. Prevent fscking when overlay is
online. Now, We cannot distinguish mounted directories if overlayfs was
- mounted with relative path.
-2. Symbolic link check.
-3. Check origin/impure/nlink xattr.
-4. ...
+ mounted with relative path. Should modify kernel together to support.
+2. Check and fix invalid redirect xattr through origin xattr.
+3. Symbolic link check.
+4. Check origin/impure/nlink xattr.
+5. Check index feature consistency.
+6. ...
--
2.9.5
next prev parent reply other threads:[~2017-12-14 6:42 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 6:47 [PATCH v2 00/18] overlay: implement fsck.overlay utility zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 01/18] overlay: implement fsck utility zhangyi (F)
2017-12-14 14:13 ` Miklos Szeredi
2017-12-14 14:33 ` Amir Goldstein
2017-12-14 14:47 ` Miklos Szeredi
2017-12-14 15:03 ` Amir Goldstein
2017-12-14 15:10 ` Miklos Szeredi
2017-12-14 15:18 ` Amir Goldstein
2017-12-14 15:48 ` Miklos Szeredi
2017-12-14 16:03 ` Vivek Goyal
2017-12-14 16:29 ` Amir Goldstein
2017-12-15 14:18 ` Miklos Szeredi
2017-12-15 14:44 ` Amir Goldstein
2017-12-15 16:06 ` Miklos Szeredi
2017-12-15 16:14 ` Miklos Szeredi
2017-12-15 15:16 ` Vivek Goyal
2017-12-15 16:17 ` Miklos Szeredi
2017-12-14 15:21 ` Vivek Goyal
2017-12-14 15:43 ` Amir Goldstein
2017-12-14 16:12 ` Vivek Goyal
2017-12-15 4:18 ` zhangyi (F)
2017-12-15 3:35 ` zhangyi (F)
2017-12-15 7:45 ` Amir Goldstein
2017-12-15 9:13 ` zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 02/18] fsck.overlay: fix uninitialized variable zhangyi (F)
2017-12-14 9:15 ` Amir Goldstein
2017-12-14 6:47 ` [PATCH v2 03/18] fsck.overlay: add -n -p and -y options zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 04/18] fsck.overlay: add path package and split helper zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 05/18] fsck.overlay: convert path parse to use helper function zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 06/18] fsck.overlay: open lowerdirs in advance zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 07/18] fsck.overlay: check lowers use relative path zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 08/18] fsck.overlay: fix spelling mistakes zhangyi (F)
2017-12-14 9:13 ` Amir Goldstein
2017-12-14 6:47 ` [PATCH v2 09/18] fsck.overlay: add counter of checked objects zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 10/18] fsck.overlay: fix verbose flag zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 11/18] fsck.overlay: add ovl_ask_invalid helper zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 12/18] fsck.overlay: remove duplicate redirect xattr in yes mode zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 13/18] fsck.overlay: handle missing case of redirecte directory zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 14/18] fsck.overlay: correct copyright and License zhangyi (F)
2017-12-14 9:09 ` Amir Goldstein
2017-12-14 6:47 ` [PATCH v2 15/18] fsck.overlay: fix word mistake zhangyi (F)
2017-12-14 6:47 ` [PATCH v2 16/18] fsck.overlay: remove test cases zhangyi (F)
2017-12-14 9:11 ` Amir Goldstein
2017-12-14 6:47 ` [PATCH v2 17/18] fsck.overlay: not enforce overlayfs is offline in 'no changes' mode zhangyi (F)
2017-12-14 6:47 ` zhangyi (F) [this message]
2017-12-14 9:27 ` [PATCH v2 00/18] overlay: implement fsck.overlay utility Amir Goldstein
2017-12-14 10:43 ` zhangyi (F)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214064747.20999-19-yi.zhang@huawei.com \
--to=yi.zhang@huawei.com \
--cc=amir73il@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox