public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] btrfs-progs: fsck: Continue check even if we find space cache problem
@ 2018-01-15  4:27 Qu Wenruo
  0 siblings, 0 replies; only message in thread
From: Qu Wenruo @ 2018-01-15  4:27 UTC (permalink / raw)
  To: linux-btrfs, fstests

Space cache itself is not a fatal part of btrfs (especially for v1 space
cache), and if we find something wrong it can be caused by other more
serious problem.

So continue to check more important trees even we found something wrong
in free space cache.

Signed-off-by: Qu Wenruo <wqu@suse.com>
---
 cmds-check.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/cmds-check.c b/cmds-check.c
index 7fc30da83ea1..6083ac0dd032 100644
--- a/cmds-check.c
+++ b/cmds-check.c
@@ -15000,7 +15000,10 @@ int cmd_check(int argc, char **argv)
 			error("errors found in free space tree");
 		else
 			error("errors found in free space cache");
-		goto out;
+		/*
+		 * Space cache problem is not fatal, and normally indicates more
+		 * serious problem, so continue check to expose the cause.
+		 */
 	}
 
 	/*
-- 
2.15.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2018-01-15  4:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-15  4:27 [PATCH] btrfs-progs: fsck: Continue check even if we find space cache problem Qu Wenruo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox