FS/XFS testing framework
 help / color / mirror / Atom feed
* [PATCH] Fstests: btrfs/011 fix device mounted when tests aborts
@ 2018-01-16 20:10 Liu Bo
  2018-01-18 14:05 ` Anand Jain
  0 siblings, 1 reply; 2+ messages in thread
From: Liu Bo @ 2018-01-16 20:10 UTC (permalink / raw)
  To: fstests; +Cc: linux-btrfs

One of btrfs tests, btrfs/011, uses SCRATCH_DEV_POOL and puts a
non-SCRATCH_DEV device as the first one when doing mkfs, and this makes
_require_scratch{_nocheck} confused since it checks mount point with
SCRATCH_DEV only.

This adds _scratch_umount to cleanup() to umount SCRATCH_MNT by
011 itself.

Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
---
 tests/btrfs/011 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/btrfs/011 b/tests/btrfs/011
index 28f1388..f4c5309 100755
--- a/tests/btrfs/011
+++ b/tests/btrfs/011
@@ -51,6 +51,7 @@ _cleanup()
 	fi
 	wait
 	rm -f $tmp.tmp
+	_scratch_unmount > /dev/null 2>&1
 }
 trap "_cleanup; exit \$status" 0 1 2 3 15
 
-- 
2.5.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fstests: btrfs/011 fix device mounted when tests aborts
  2018-01-16 20:10 [PATCH] Fstests: btrfs/011 fix device mounted when tests aborts Liu Bo
@ 2018-01-18 14:05 ` Anand Jain
  0 siblings, 0 replies; 2+ messages in thread
From: Anand Jain @ 2018-01-18 14:05 UTC (permalink / raw)
  To: Liu Bo, fstests; +Cc: linux-btrfs



On 01/17/2018 04:10 AM, Liu Bo wrote:
> One of btrfs tests, btrfs/011, uses SCRATCH_DEV_POOL and puts a
> non-SCRATCH_DEV device as the first one when doing mkfs, and this makes
> _require_scratch{_nocheck} confused since it checks mount point with
> SCRATCH_DEV only.
> 
> This adds _scratch_umount to cleanup() to umount SCRATCH_MNT by
> 011 itself.
> 
> Signed-off-by: Liu Bo <bo.li.liu@oracle.com>

Reviewed-by: Anand Jain <anand.jain@oracle.com>
Tested-by: Anand Jain <anand.jain@oracle.com>

Thanks, Anand

> ---
>   tests/btrfs/011 | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/btrfs/011 b/tests/btrfs/011
> index 28f1388..f4c5309 100755
> --- a/tests/btrfs/011
> +++ b/tests/btrfs/011
> @@ -51,6 +51,7 @@ _cleanup()
>   	fi
>   	wait
>   	rm -f $tmp.tmp
> +	_scratch_unmount > /dev/null 2>&1
>   }
>   trap "_cleanup; exit \$status" 0 1 2 3 15
>   
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-18 14:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-16 20:10 [PATCH] Fstests: btrfs/011 fix device mounted when tests aborts Liu Bo
2018-01-18 14:05 ` Anand Jain

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox