From: Christoph Hellwig <hch@infradead.org>
To: Rostislav <rostislav@tuxera.com>
Cc: Christoph Hellwig <hch@infradead.org>, fstests@vger.kernel.org
Subject: Re: [PATCH v2 6/8] fssum: Use bswap_64() instead of __bswap_64()
Date: Mon, 22 Jan 2018 23:44:12 -0800 [thread overview]
Message-ID: <20180123074412.GA26914@infradead.org> (raw)
In-Reply-To: <BDC32FA7-9CC0-42A2-9D59-43C9F7FAF5C4@tuxera.com>
On Tue, Jan 23, 2018 at 09:36:15AM +0200, Rostislav wrote:
> Thanks for your feedback! We can of course use htobe64(), but the file
> src/fssum.c already defines htonll() in a way that takes endianness into
> account, and using htobe64() would be equivalent to htonll(). My strategy when
> writing this patch set was to make the least number of modifications required
> to build with musl libc.
And normally our strategy in maintaining xfs related code is to do the
right thing even if it is a little more invasive. Using htobe64 would
be the choice based on that.
next prev parent reply other threads:[~2018-01-23 7:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 15:57 [PATCH v2 0/8] Fix build with musl libc Rostislav Skudnov
2018-01-22 15:57 ` [PATCH v2 1/8] fsstress: Include stddef.h for ptrdiff_t Rostislav Skudnov
2018-01-22 20:21 ` Christoph Hellwig
2018-01-23 4:01 ` Eryu Guan
2018-01-22 15:57 ` [PATCH v2 2/8] Replace all __[u]intNN_t types with standard [u]intNN_t Rostislav Skudnov
2018-01-22 20:22 ` Christoph Hellwig
2018-01-22 15:57 ` [PATCH v2 3/8] doio, growfiles: Use standard signal name SIGCHLD instead of SIGCLD Rostislav Skudnov
2018-01-22 20:22 ` Christoph Hellwig
2018-01-22 15:57 ` [PATCH v2 4/8] metaperf: Include linux/param.h explicitly for HZ macro Rostislav Skudnov
2018-01-22 20:24 ` Christoph Hellwig
2018-01-24 3:58 ` Eryu Guan
2018-01-25 0:02 ` Dave Chinner
2018-01-28 10:46 ` Eryu Guan
2018-01-27 3:16 ` Dave Chinner
2018-01-27 3:56 ` Dave Chinner
2018-01-22 15:57 ` [PATCH v2 5/8] dmiperf: Include sys/types.h for u_int32_t Rostislav Skudnov
2018-01-22 20:24 ` Christoph Hellwig
2018-01-24 4:00 ` Eryu Guan
2018-01-22 15:57 ` [PATCH v2 6/8] fssum: Use bswap_64() instead of __bswap_64() Rostislav Skudnov
2018-01-22 20:26 ` Christoph Hellwig
2018-01-23 7:36 ` Rostislav
2018-01-23 7:44 ` Christoph Hellwig [this message]
2018-01-23 8:08 ` [PATCH v3 6/8] fssum: Use htobe64() instead of a custom macro Rostislav Skudnov
2018-01-23 11:21 ` Christoph Hellwig
2018-01-22 15:57 ` [PATCH v2 7/8] t_mtab: Replace sys_siglist[] with strsignal() Rostislav Skudnov
2018-01-22 20:26 ` Christoph Hellwig
2018-01-22 15:57 ` [PATCH v2 8/8] pwrite_mmap_blocked: Include signal.h instead of sys/signal.h Rostislav Skudnov
2018-01-22 20:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123074412.GA26914@infradead.org \
--to=hch@infradead.org \
--cc=fstests@vger.kernel.org \
--cc=rostislav@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox