From: Eryu Guan <eguan@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Rostislav Skudnov <rostislav@tuxera.com>, fstests@vger.kernel.org
Subject: Re: [PATCH v2 4/8] metaperf: Include linux/param.h explicitly for HZ macro
Date: Wed, 24 Jan 2018 11:58:59 +0800 [thread overview]
Message-ID: <20180124035859.GA30514@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20180122202406.GD16776@infradead.org>
On Mon, Jan 22, 2018 at 12:24:06PM -0800, Christoph Hellwig wrote:
> On Mon, Jan 22, 2018 at 03:57:15PM +0000, Rostislav Skudnov wrote:
> > Glibc includes linux/param.h when we include sys/param.h, whereas musl
> > libc does not do that. HZ is a Linux-specific macro, therefore include
> > the header file that defines it explicitly.
> >
> > Signed-off-by: Rostislav Skudnov <rostislav@tuxera.com>
>
> Using HZ in userspace doesn't make any sense at all. The kernel HZ
> (as in the granulairy for jiffies) can vary between architectures
> and even configurations. I guess it wants a hard coded 100 here, but
> someone will have to do a detailed analysis.
No one is using metaperf now, all the old benchmark infrastructure was
removed by commit b020416d51ff ("xfstests: remove bench infrastructure")
I think we can remove src/metaperf.c too.
Thanks,
Eryu
next prev parent reply other threads:[~2018-01-24 3:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 15:57 [PATCH v2 0/8] Fix build with musl libc Rostislav Skudnov
2018-01-22 15:57 ` [PATCH v2 1/8] fsstress: Include stddef.h for ptrdiff_t Rostislav Skudnov
2018-01-22 20:21 ` Christoph Hellwig
2018-01-23 4:01 ` Eryu Guan
2018-01-22 15:57 ` [PATCH v2 2/8] Replace all __[u]intNN_t types with standard [u]intNN_t Rostislav Skudnov
2018-01-22 20:22 ` Christoph Hellwig
2018-01-22 15:57 ` [PATCH v2 3/8] doio, growfiles: Use standard signal name SIGCHLD instead of SIGCLD Rostislav Skudnov
2018-01-22 20:22 ` Christoph Hellwig
2018-01-22 15:57 ` [PATCH v2 4/8] metaperf: Include linux/param.h explicitly for HZ macro Rostislav Skudnov
2018-01-22 20:24 ` Christoph Hellwig
2018-01-24 3:58 ` Eryu Guan [this message]
2018-01-25 0:02 ` Dave Chinner
2018-01-28 10:46 ` Eryu Guan
2018-01-27 3:16 ` Dave Chinner
2018-01-27 3:56 ` Dave Chinner
2018-01-22 15:57 ` [PATCH v2 5/8] dmiperf: Include sys/types.h for u_int32_t Rostislav Skudnov
2018-01-22 20:24 ` Christoph Hellwig
2018-01-24 4:00 ` Eryu Guan
2018-01-22 15:57 ` [PATCH v2 6/8] fssum: Use bswap_64() instead of __bswap_64() Rostislav Skudnov
2018-01-22 20:26 ` Christoph Hellwig
2018-01-23 7:36 ` Rostislav
2018-01-23 7:44 ` Christoph Hellwig
2018-01-23 8:08 ` [PATCH v3 6/8] fssum: Use htobe64() instead of a custom macro Rostislav Skudnov
2018-01-23 11:21 ` Christoph Hellwig
2018-01-22 15:57 ` [PATCH v2 7/8] t_mtab: Replace sys_siglist[] with strsignal() Rostislav Skudnov
2018-01-22 20:26 ` Christoph Hellwig
2018-01-22 15:57 ` [PATCH v2 8/8] pwrite_mmap_blocked: Include signal.h instead of sys/signal.h Rostislav Skudnov
2018-01-22 20:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124035859.GA30514@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=rostislav@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox