From: "zhangyi (F)" <yi.zhang@huawei.com>
To: linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Cc: miklos@szeredi.hu, amir73il@gmail.com, eguan@redhat.com,
yi.zhang@huawei.com, miaoxie@huawei.com, yangerkun@huawei.com
Subject: [xfstests PATCH v6 1/8] common/rc: modify mounted check helper
Date: Wed, 24 Jan 2018 15:33:37 +0800 [thread overview]
Message-ID: <20180124073344.31970-2-yi.zhang@huawei.com> (raw)
In-Reply-To: <20180124073344.31970-1-yi.zhang@huawei.com>
Modify _is_mounted() to accept a dir and fstype as input, and check
whether this dir is a mount point of specified fstype. This patch also
fix the problem of invalid fstype check and remove invalid error
message.
Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
---
common/rc | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/common/rc b/common/rc
index 77a4eb4..2e7aee5 100644
--- a/common/rc
+++ b/common/rc
@@ -2372,27 +2372,27 @@ _scratch_mkfs_richacl()
esac
}
-# check that a FS on a device is mounted
+# check that a FS on a device is mounted or a dir is a mount point
# if so, return mount point
#
_is_mounted()
{
- if [ $# -ne 1 ]
- then
- echo "Usage: _is_mounted device" 1>&2
- exit 1
- fi
+ local name
+ local fstype
- device=$1
+ if [ $# -eq 2 ]; then
+ name=$1
+ fstype=$2
+ elif [ $# -eq 1 ]; then
+ name=$1
+ else
+ echo "Usage: _is_mounted <device|mountpoint> [fstype]" 1>&2
+ exit 1
+ fi
- if _mount | grep "$device " | $AWK_PROG -v pattern="type $FSTYP" '
- pattern { print $3 ; exit 0 }
- END { exit 1 }
- '
- then
- echo "_is_mounted: $device is not a mounted $FSTYP FS"
- exit 1
- fi
+ _mount | grep "$name " | $AWK_PROG -v pattern="type $fstype" '
+ $0 ~ pattern { print $3 }
+ '
}
# remount a FS to a new mode (ro or rw)
--
2.9.5
next prev parent reply other threads:[~2018-01-24 7:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 7:33 [xfstests PATCH v6 0/8] overlay: add fsck.overlay basic tests zhangyi (F)
2018-01-24 7:33 ` zhangyi (F) [this message]
2018-01-24 9:23 ` [xfstests PATCH v6 1/8] common/rc: modify mounted check helper Amir Goldstein
2018-01-24 7:33 ` [xfstests PATCH v6 2/8] overlay: add filesystem " zhangyi (F)
2018-01-24 9:31 ` Amir Goldstein
2018-01-24 10:53 ` zhangyi (F)
2018-01-24 7:33 ` [xfstests PATCH v6 3/8] overlay: add fsck.overlay whiteout test zhangyi (F)
2018-01-24 7:33 ` [xfstests PATCH v6 4/8] overlay: add fsck.overlay redirect directory test zhangyi (F)
2018-01-24 7:33 ` [xfstests PATCH v6 5/8] overlay: add fsck.overlay impure xattr test zhangyi (F)
2018-01-24 7:33 ` [xfstests PATCH v6 6/8] overlay/003: fix fs check failure zhangyi (F)
2018-01-24 7:33 ` [xfstests PATCH v6 7/8] overlay: skip check for tests finished with corrupt filesystem zhangyi (F)
2018-01-24 7:33 ` [xfstests PATCH v6 8/8] overlay: correct scratch dirs check zhangyi (F)
2018-01-24 9:34 ` Amir Goldstein
2018-01-24 9:41 ` [xfstests PATCH v6 0/8] overlay: add fsck.overlay basic tests Amir Goldstein
2018-01-24 10:37 ` zhangyi (F)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124073344.31970-2-yi.zhang@huawei.com \
--to=yi.zhang@huawei.com \
--cc=amir73il@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=miklos@szeredi.hu \
--cc=yangerkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox