From: "zhangyi (F)" <yi.zhang@huawei.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: overlayfs <linux-unionfs@vger.kernel.org>,
fstests <fstests@vger.kernel.org>,
Miklos Szeredi <miklos@szeredi.hu>, Eryu Guan <eguan@redhat.com>,
Miao Xie <miaoxie@huawei.com>,
yangerkun@huawei.com
Subject: Re: [xfstests PATCH v6 2/8] overlay: add filesystem check helper
Date: Wed, 24 Jan 2018 18:53:35 +0800 [thread overview]
Message-ID: <21bd824d-49cd-5749-ca1d-238154e321e7@huawei.com> (raw)
In-Reply-To: <CAOQ4uxjwrFDKn6iYTNLA02z-GvG-X+72Vs4TYs1sL0_8wiuksg@mail.gmail.com>
On 2018/1/24 17:31, Amir Goldstein Write:
> On Wed, Jan 24, 2018 at 9:33 AM, zhangyi (F) <yi.zhang@huawei.com> wrote:
>> +_overlay_check_fs()
>> +{
>> + local ovl_mnt=$1
>> + local base_dev=$4
>> + local base_mnt=$5
>> + shift 1
>> +
>> + [ "$FSTYP" = overlay ] || return 0
>> +
>> + # Base fs needs to be mounted to check overlay dirs
>> + local base_mounted=""
>> + [ -z "$base_dev" ] || base_mounted=`_is_mounted $base_dev`
>
> That looks like I have a bug in my original implementation of _overlay_check_fs
> because $FSTYP" = overlay _is_mounted here will not actually find a mounted
> base dev. Need to pass $OVL_BASE_FSTYP to your improved _is_mounted
> helper.
> No?
>
Yes, we not found this bug becasue previous _is_mounted missing $FSTYP check,
I will improve it as you suggested.
Thanks,
Yi.
next prev parent reply other threads:[~2018-01-24 10:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 7:33 [xfstests PATCH v6 0/8] overlay: add fsck.overlay basic tests zhangyi (F)
2018-01-24 7:33 ` [xfstests PATCH v6 1/8] common/rc: modify mounted check helper zhangyi (F)
2018-01-24 9:23 ` Amir Goldstein
2018-01-24 7:33 ` [xfstests PATCH v6 2/8] overlay: add filesystem " zhangyi (F)
2018-01-24 9:31 ` Amir Goldstein
2018-01-24 10:53 ` zhangyi (F) [this message]
2018-01-24 7:33 ` [xfstests PATCH v6 3/8] overlay: add fsck.overlay whiteout test zhangyi (F)
2018-01-24 7:33 ` [xfstests PATCH v6 4/8] overlay: add fsck.overlay redirect directory test zhangyi (F)
2018-01-24 7:33 ` [xfstests PATCH v6 5/8] overlay: add fsck.overlay impure xattr test zhangyi (F)
2018-01-24 7:33 ` [xfstests PATCH v6 6/8] overlay/003: fix fs check failure zhangyi (F)
2018-01-24 7:33 ` [xfstests PATCH v6 7/8] overlay: skip check for tests finished with corrupt filesystem zhangyi (F)
2018-01-24 7:33 ` [xfstests PATCH v6 8/8] overlay: correct scratch dirs check zhangyi (F)
2018-01-24 9:34 ` Amir Goldstein
2018-01-24 9:41 ` [xfstests PATCH v6 0/8] overlay: add fsck.overlay basic tests Amir Goldstein
2018-01-24 10:37 ` zhangyi (F)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21bd824d-49cd-5749-ca1d-238154e321e7@huawei.com \
--to=yi.zhang@huawei.com \
--cc=amir73il@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=miklos@szeredi.hu \
--cc=yangerkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox