From: "zhangyi (F)" <yi.zhang@huawei.com>
To: eguan@redhat.com, fstests@vger.kernel.org
Cc: linux-unionfs@vger.kernel.org, miklos@szeredi.hu,
amir73il@gmail.com, yi.zhang@huawei.com, miaoxie@huawei.com,
yangerkun@huawei.com
Subject: [xfstests PATCH v2 1/5] common/rc: improve mounted check helper
Date: Wed, 31 Jan 2018 18:27:55 +0800 [thread overview]
Message-ID: <20180131102759.40997-2-yi.zhang@huawei.com> (raw)
In-Reply-To: <20180131102759.40997-1-yi.zhang@huawei.com>
Modify _is_mounted() to accept a dir and fstype as input, and check
whether this dir is a specified type of mount point.
This patch also fix the problem of missing fstype check:
For example:
Base mounted filesystem:
/dev/sda2 on /boot type ext4 (rw,relatime,data=ordered)
FSTYPE=xfs
mountpoint=`_is_mounted /dev/sda1`
echo "$mountpoint"
Output: /boot
This patch remove the useless error message, return empty if no
valid mount point.
Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
---
common/rc | 25 ++++++++++---------------
1 file changed, 10 insertions(+), 15 deletions(-)
diff --git a/common/rc b/common/rc
index 2e3a83a..3351f00 100644
--- a/common/rc
+++ b/common/rc
@@ -2372,27 +2372,22 @@ _scratch_mkfs_richacl()
esac
}
-# check that a FS on a device is mounted
+# check that a FS on a device is mounted or a dir is a mount point
# if so, return mount point
#
_is_mounted()
{
- if [ $# -ne 1 ]
- then
- echo "Usage: _is_mounted device" 1>&2
- exit 1
- fi
+ if [ $# -lt 1 ]; then
+ echo "Usage: _is_mounted <device|mountpoint> [fstype]" 1>&2
+ exit 1
+ fi
- device=$1
+ local name=$1
+ local fstype=${2-$FSTYP}
- if _mount | grep "$device " | $AWK_PROG -v pattern="type $FSTYP" '
- pattern { print $3 ; exit 0 }
- END { exit 1 }
- '
- then
- echo "_is_mounted: $device is not a mounted $FSTYP FS"
- exit 1
- fi
+ _mount | grep "$name " | $AWK_PROG -v pattern="type $fstype" '
+ $0 ~ pattern { print $3 }
+ '
}
# remount a FS to a new mode (ro or rw)
--
2.5.0
next prev parent reply other threads:[~2018-01-31 10:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 10:27 [xfstests PATCH v2 0/5] overlay: add overlay filesystem dirs check zhangyi (F)
2018-01-31 10:27 ` zhangyi (F) [this message]
2018-02-06 15:21 ` [xfstests PATCH v2 1/5] common/rc: improve mounted check helper Eryu Guan
2018-01-31 10:27 ` [xfstests PATCH v2 2/5] overlay: hook filesystem " zhangyi (F)
2018-02-06 15:53 ` Eryu Guan
2018-02-06 20:34 ` Amir Goldstein
2018-02-07 4:13 ` Eryu Guan
2018-02-08 12:46 ` zhangyi (F)
2018-01-31 10:27 ` [xfstests PATCH v2 3/5] overlay/003: fix fs check failure zhangyi (F)
2018-01-31 10:27 ` [xfstests PATCH v2 4/5] overlay: skip check for tests finished with corrupt filesystem zhangyi (F)
2018-01-31 10:27 ` [xfstests PATCH v2 5/5] overlay: correct scratch dirs check zhangyi (F)
2018-01-31 15:50 ` Amir Goldstein
2018-02-06 16:11 ` Eryu Guan
2018-02-06 16:14 ` [xfstests PATCH v2 0/5] overlay: add overlay filesystem " Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180131102759.40997-2-yi.zhang@huawei.com \
--to=yi.zhang@huawei.com \
--cc=amir73il@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=miklos@szeredi.hu \
--cc=yangerkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox