Re: [PATCH] fstests: _fail test by default when _scratch_mount fails

["Darrick J. Wong" <darrick.wong@oracle.com>]

On Sun, Feb 18, 2018 at 08:44:57PM +0800, Eryu Guan wrote:
> Previously _scratch_mount didn't check the mount status and most
> tests continue to run even if the mount failed (unless test checks
> for the mount status explicitly). This would result in running tests
> on the underlying filesystem (usually rootfs) and implicit test
> failures, and such failures can be annoying and are usually hard to
> debug.
> 
> Now _fail test by default if _scratch_mount failed and introduce
> _try_scratch_mount for tests that need to check mount results
> themselves. Also introduce a new _try_scratch_mount helper that does
> scratch mount without checking mount status for tests that do the
> check themselves.
> 
> Suggested-by: Andreas Gruenbacher <agruenba@redhat.com>
> Signed-off-by: Eryu Guan <eguan@redhat.com>

The common/generic/shared/xfs parts look ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

(The ext4/btrfs parts seemed ok at a quick glance, but I'm not as
familiar with them.)

--D