Re: [PATCH] fstests: _fail test by default when _scratch_mount fails

[Eryu Guan <eguan@redhat.com>]

On Wed, Feb 21, 2018 at 11:27:01AM +0100, Andreas Gruenbacher wrote:
> On 18 February 2018 at 13:44, Eryu Guan <eguan@redhat.com> wrote:
> > Previously _scratch_mount didn't check the mount status and most
> > tests continue to run even if the mount failed (unless test checks
> > for the mount status explicitly). This would result in running tests
> > on the underlying filesystem (usually rootfs) and implicit test
> > failures, and such failures can be annoying and are usually hard to
> > debug.
> >
> > Now _fail test by default if _scratch_mount failed and introduce
> > _try_scratch_mount for tests that need to check mount results
> > themselves. Also introduce a new _try_scratch_mount helper that does
> > scratch mount without checking mount status for tests that do the
> > check themselves.
> 
> The message above doesn't look quite right, but the patch looks good.

Ah, I'll fix that up.

> 
> Reviewed-by: Andreas Gruenbacher <agruenba@redhat.com>

Thanks for review!

Eryu