[PATCH] btrfs/149: don't run if PAGE_SIZE > 4096

[PATCH] btrfs/149: don't run if PAGE_SIZE > 4096

[Mark Fasheh]

The test assumes a 4K block size and fails on larger block sizes - the
extent layout will not match and the reflink command will fail.

Signed-off-by: Mark Fasheh <mfasheh@suse.de>
---
 tests/btrfs/149 | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/btrfs/149 b/tests/btrfs/149
index 3e955a30..64bc8ac3 100755
--- a/tests/btrfs/149
+++ b/tests/btrfs/149
@@ -37,6 +37,12 @@ _require_scratch
 _require_scratch_reflink
 _require_odirect
 
+# Test output will not match results if page size > 4096
+PAGE_SIZE=`getconf PAGE_SIZE`
+if [ $PAGE_SIZE -gt 4096 ]; then
+    _notrun "Not supported with page size > 4096"
+fi
+
 send_files_dir=$TEST_DIR/btrfs-test-$seq
 
 rm -f $seqres.full
-- 
2.15.1

Re: [PATCH] btrfs/149: don't run if PAGE_SIZE > 4096

[Dave Chinner]

On Fri, Jun 22, 2018 at 11:38:43PM +0200, Mark Fasheh wrote:
> The test assumes a 4K block size and fails on larger block sizes - the
> extent layout will not match and the reflink command will fail.

The usual way of fixing this is it use 64k sizes and offsets for IO
rather than 4k, and change the output to match. That way the test
should behave the same across all supported block and page sizes.
> 
> Signed-off-by: Mark Fasheh <mfasheh@suse.de>
> ---
>  tests/btrfs/149 | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tests/btrfs/149 b/tests/btrfs/149
> index 3e955a30..64bc8ac3 100755
> --- a/tests/btrfs/149
> +++ b/tests/btrfs/149
> @@ -37,6 +37,12 @@ _require_scratch
>  _require_scratch_reflink
>  _require_odirect
>  
> +# Test output will not match results if page size > 4096
> +PAGE_SIZE=`getconf PAGE_SIZE`
> +if [ $PAGE_SIZE -gt 4096 ]; then
> +    _notrun "Not supported with page size > 4096"
> +fi

FWIW, the commi description talks about block sizes - this tests the
machien page size, not the filesystem block size....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com