public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfs/270: allow corrupted xfs_db write
@ 2018-09-25 18:16 Eric Sandeen
  2018-09-26  0:13 ` Darrick J. Wong
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2018-09-25 18:16 UTC (permalink / raw)
  To: fstests

Upcoming verifiers treat the unknown ro_compat flag written via xfs_db
as corruption, so use the -d flag to allow it, and filter our the
resulting informational message.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/tests/xfs/270 b/tests/xfs/270
index d5c8df19..da66bc33 100755
--- a/tests/xfs/270
+++ b/tests/xfs/270
@@ -44,7 +44,8 @@ _scratch_mkfs_xfs >>$seqres.full 2>&1
 # set the highest bit of features_ro_compat, use it as an unknown
 # feature bit. If one day this bit become known feature, please
 # change this case.
-$XFS_DB_PROG -x -c "sb 0" -c "write features_ro_compat $((2**31))" $SCRATCH_DEV
+$XFS_DB_PROG -x -c "sb 0" -c "write -d features_ro_compat $((2**31))" \
+	$SCRATCH_DEV | grep -v "Allowing write of corrupted data"
 
 # rw mount with unknown ro-compat feature should fail
 echo "rw mount test"

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] xfs/270: allow corrupted xfs_db write
  2018-09-25 18:16 [PATCH] xfs/270: allow corrupted xfs_db write Eric Sandeen
@ 2018-09-26  0:13 ` Darrick J. Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2018-09-26  0:13 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: fstests

On Tue, Sep 25, 2018 at 01:16:16PM -0500, Eric Sandeen wrote:
> Upcoming verifiers treat the unknown ro_compat flag written via xfs_db
> as corruption, so use the -d flag to allow it, and filter our the
> resulting informational message.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> 
> diff --git a/tests/xfs/270 b/tests/xfs/270
> index d5c8df19..da66bc33 100755
> --- a/tests/xfs/270
> +++ b/tests/xfs/270
> @@ -44,7 +44,8 @@ _scratch_mkfs_xfs >>$seqres.full 2>&1
>  # set the highest bit of features_ro_compat, use it as an unknown
>  # feature bit. If one day this bit become known feature, please
>  # change this case.
> -$XFS_DB_PROG -x -c "sb 0" -c "write features_ro_compat $((2**31))" $SCRATCH_DEV
> +$XFS_DB_PROG -x -c "sb 0" -c "write -d features_ro_compat $((2**31))" \
> +	$SCRATCH_DEV | grep -v "Allowing write of corrupted data"
>  
>  # rw mount with unknown ro-compat feature should fail
>  echo "rw mount test"
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-09-26  6:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-25 18:16 [PATCH] xfs/270: allow corrupted xfs_db write Eric Sandeen
2018-09-26  0:13 ` Darrick J. Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox