public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] generic: update group file to indicate generic/456 uses {collapse,zero}_range
@ 2018-10-26 11:53 Theodore Ts'o
  2018-10-26 14:40 ` Bill O'Donnell
  2018-10-27  9:22 ` Filipe Manana
  0 siblings, 2 replies; 4+ messages in thread
From: Theodore Ts'o @ 2018-10-26 11:53 UTC (permalink / raw)
  To: fstests; +Cc: Theodore Ts'o

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
 tests/generic/group | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/group b/tests/generic/group
index 28452732..8a21970e 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -458,7 +458,7 @@
 453 auto quick dir
 454 auto quick attr
 455 auto log replay
-456 auto quick metadata
+456 auto quick metadata collapse zero
 457 auto log replay clone
 458 auto quick clone collapse zero
 459 auto thin
-- 
2.18.0.rc0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] generic: update group file to indicate generic/456 uses {collapse,zero}_range
  2018-10-26 11:53 [PATCH] generic: update group file to indicate generic/456 uses {collapse,zero}_range Theodore Ts'o
@ 2018-10-26 14:40 ` Bill O'Donnell
  2018-10-27  9:22 ` Filipe Manana
  1 sibling, 0 replies; 4+ messages in thread
From: Bill O'Donnell @ 2018-10-26 14:40 UTC (permalink / raw)
  To: Theodore Ts'o; +Cc: fstests

On Fri, Oct 26, 2018 at 07:53:49AM -0400, Theodore Ts'o wrote:
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> ---

Reviewed-by: Bill O'Donnell <billodo@redhat.com>

>  tests/generic/group | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/group b/tests/generic/group
> index 28452732..8a21970e 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -458,7 +458,7 @@
>  453 auto quick dir
>  454 auto quick attr
>  455 auto log replay
> -456 auto quick metadata
> +456 auto quick metadata collapse zero
>  457 auto log replay clone
>  458 auto quick clone collapse zero
>  459 auto thin
> -- 
> 2.18.0.rc0
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] generic: update group file to indicate generic/456 uses {collapse,zero}_range
  2018-10-26 11:53 [PATCH] generic: update group file to indicate generic/456 uses {collapse,zero}_range Theodore Ts'o
  2018-10-26 14:40 ` Bill O'Donnell
@ 2018-10-27  9:22 ` Filipe Manana
  2018-10-28 13:35   ` Eryu Guan
  1 sibling, 1 reply; 4+ messages in thread
From: Filipe Manana @ 2018-10-27  9:22 UTC (permalink / raw)
  To: Theodore Tso; +Cc: fstests

On Fri, Oct 26, 2018 at 12:53 PM Theodore Ts'o <tytso@mit.edu> wrote:
>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> ---
>  tests/generic/group | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/group b/tests/generic/group
> index 28452732..8a21970e 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -458,7 +458,7 @@
>  453 auto quick dir
>  454 auto quick attr
>  455 auto log replay
> -456 auto quick metadata
> +456 auto quick metadata collapse zero

Since it uses fallocate too, should also be in the 'prealloc' group.

Thanks.

>  457 auto log replay clone
>  458 auto quick clone collapse zero
>  459 auto thin
> --
> 2.18.0.rc0
>


-- 
Filipe David Manana,

“Whether you think you can, or you think you can't — you're right.”

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] generic: update group file to indicate generic/456 uses {collapse,zero}_range
  2018-10-27  9:22 ` Filipe Manana
@ 2018-10-28 13:35   ` Eryu Guan
  0 siblings, 0 replies; 4+ messages in thread
From: Eryu Guan @ 2018-10-28 13:35 UTC (permalink / raw)
  To: Filipe Manana; +Cc: Theodore Tso, fstests

On Sat, Oct 27, 2018 at 10:22:16AM +0100, Filipe Manana wrote:
> On Fri, Oct 26, 2018 at 12:53 PM Theodore Ts'o <tytso@mit.edu> wrote:
> >
> > Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> > ---
> >  tests/generic/group | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/generic/group b/tests/generic/group
> > index 28452732..8a21970e 100644
> > --- a/tests/generic/group
> > +++ b/tests/generic/group
> > @@ -458,7 +458,7 @@
> >  453 auto quick dir
> >  454 auto quick attr
> >  455 auto log replay
> > -456 auto quick metadata
> > +456 auto quick metadata collapse zero
> 
> Since it uses fallocate too, should also be in the 'prealloc' group.

I'll add it on commit, thanks for review!

Eryu

> 
> Thanks.
> 
> >  457 auto log replay clone
> >  458 auto quick clone collapse zero
> >  459 auto thin
> > --
> > 2.18.0.rc0
> >
> 
> 
> -- 
> Filipe David Manana,
> 
> “Whether you think you can, or you think you can't — you're right.”

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-10-28 22:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-26 11:53 [PATCH] generic: update group file to indicate generic/456 uses {collapse,zero}_range Theodore Ts'o
2018-10-26 14:40 ` Bill O'Donnell
2018-10-27  9:22 ` Filipe Manana
2018-10-28 13:35   ` Eryu Guan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox