public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] check: use full paths for diff on error
@ 2018-11-02  1:09 Dave Chinner
  0 siblings, 0 replies; only message in thread
From: Dave Chinner @ 2018-11-02  1:09 UTC (permalink / raw)
  To: fstests

From: Dave Chinner <dchinner@redhat.com>

i don't run fstests from the source directory, so when I get a
golden image mismatch the relative path to the golden output is
not useful:

(Run 'diff -u tests/generic/013.out /home/dave/src/xfstests-dev/results//xfs_64k/generic/013.out.bad'  to see the entire diff)

Change the output to emit the real path for the golden out so this
can be cut and pasted and run from anywhere.

(Run 'diff -u /home/dave/src/xfstests-dev/tests/generic/013.out /home/dave/src/xfstests-dev/results//xfs_64k/generic/013.out.bad'  to see the entire diff)

Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
 check | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/check b/check
index f3c8021d94b9..59f94c1c33f9 100755
--- a/check
+++ b/check
@@ -799,7 +799,7 @@ for section in $HOST_OPTIONS_SECTIONS; do
 			else
 				head -n "$DIFF_LENGTH"
 				echo "..."
-				echo "(Run '$diff $seq.out $seqres.out.bad'" \
+				echo "(Run '$diff $here/$seq.out $seqres.out.bad'" \
 					" to see the entire diff)"
 			fi; } | sed -e 's/^\(.\)/    \1/'
 			err=true
-- 
2.19.1

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2018-11-02 10:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-02  1:09 [PATCH] check: use full paths for diff on error Dave Chinner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox