From: Dave Chinner <david@fromorbit.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: fstests <fstests@vger.kernel.org>, linux-api@vger.kernel.org
Subject: Re: [PATCH 2/3] generic/43[014]: copy_range beyond source EOF should fail
Date: Mon, 3 Dec 2018 19:10:34 +1100 [thread overview]
Message-ID: <20181203081034.GW19305@dastard> (raw)
In-Reply-To: <CAOQ4uxgqadtGXDU3UJAJeFGwNKOW1d4Ti8bmVZ3_ycMeK-CAow@mail.gmail.com>
On Mon, Dec 03, 2018 at 09:30:58AM +0200, Amir Goldstein wrote:
> On Mon, Dec 3, 2018 at 8:43 AM Dave Chinner <david@fromorbit.com> wrote:
> >
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > As per the copy_file_range() man page:
> >
> > EINVAL
> > Requested range extends beyond the end of the source file;
> > .....
> >
> > These tests actually attempt to copy beyond the end of the source
> > file and so should fail with EINVAL. The kernel does not check this
> > and so needs fixing. These operations should fail, so fix the tests.
> >
>
> [cc: linux-api]
>
> Probably better to discuss this on the kernel patch itself, but well...
I'm getting there - the problem is I need to refer to the tests in
the series description that these changes are made.
> How confident are you about this change not breaking existing programs?
My care factor is way below zero. The API implementation is so
broken right now that fixing it is almost guaranteed to break
something somewhere.
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-12-03 8:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 6:42 [PATCH 0/3] fstests: copy_file_range() bounds testing Dave Chinner
2018-12-03 6:42 ` [PATCH 1/3] common: add _require_test_swapfile Dave Chinner
2018-12-03 16:43 ` Darrick J. Wong
2018-12-13 12:16 ` Xiao Yang
2018-12-18 21:54 ` Dave Chinner
2018-12-03 6:42 ` [PATCH 2/3] generic/43[014]: copy_range beyond source EOF should fail Dave Chinner
2018-12-03 7:30 ` Amir Goldstein
2018-12-03 8:10 ` Dave Chinner [this message]
2018-12-03 16:47 ` Darrick J. Wong
2018-12-05 22:23 ` Dave Chinner
2018-12-03 6:42 ` [PATCH 3/3] generic: copy_file_range bounds test Dave Chinner
2018-12-03 7:25 ` Amir Goldstein
2018-12-03 8:17 ` Dave Chinner
2018-12-03 9:22 ` Amir Goldstein
2018-12-03 13:15 ` Amir Goldstein
2019-05-13 6:03 ` Amir Goldstein
2018-12-03 16:58 ` Darrick J. Wong
2019-05-21 5:33 ` Amir Goldstein
2018-12-03 16:41 ` [PATCH 0/3] fstests: copy_file_range() bounds testing Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203081034.GW19305@dastard \
--to=david@fromorbit.com \
--cc=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox