public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] check: fix -X exclude_file behaviour
@ 2018-12-19 15:41 David Disseldorp
  0 siblings, 0 replies; only message in thread
From: David Disseldorp @ 2018-12-19 15:41 UTC (permalink / raw)
  To: fstests; +Cc: David Disseldorp

It is currently processed before FSTYP has been properly set, leading to
xfs, btrfs, etc. specific exclude_files being ignored.

Signed-off-by: David Disseldorp <ddiss@suse.de>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
---
 check | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/check b/check
index 59f94c1c..5f8210d7 100755
--- a/check
+++ b/check
@@ -22,6 +22,7 @@ have_test_arg=false
 randomize=false
 export here=`pwd`
 xfile=""
+subdir_xfile=""
 brief_test_summary=false
 do_report=false
 DUMP_OUTPUT=false
@@ -272,13 +273,7 @@ while [ $# -gt 0 ]; do
 		XGROUP_LIST="$XGROUP_LIST ${xgroup//,/ }"
 		;;
 
-	-X)	xfile=$2; shift ;
-		for d in $SRC_GROUPS $FSTYP; do
-			[ -f $SRC_DIR/$d/$xfile ] || continue
-			for f in `sed "s/#.*$//" $SRC_DIR/$d/$xfile`; do
-				echo $d/$f >> $tmp.xlist
-			done
-		done
+	-X)	subdir_xfile=$2; shift ;
 		;;
 	-E)	xfile=$2; shift ;
 		if [ -f $xfile ]; then
@@ -325,6 +320,15 @@ if ! . ./common/rc; then
 	exit 1
 fi
 
+if [ -n "$subdir_xfile" ]; then
+	for d in $SRC_GROUPS $FSTYP; do
+		[ -f $SRC_DIR/$d/$subdir_xfile ] || continue
+		for f in `sed "s/#.*$//" $SRC_DIR/$d/$subdir_xfile`; do
+			echo $d/$f >> $tmp.xlist
+		done
+	done
+fi
+
 # Process tests from command line now.
 if $have_test_arg; then
 	while [ $# -gt 0 ]; do
-- 
2.13.7

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2018-12-19 15:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-19 15:41 [PATCH] check: fix -X exclude_file behaviour David Disseldorp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox