From: Hou Tao <houtao1@huawei.com>
To: fstests@vger.kernel.org
Cc: houtao1@huawei.com
Subject: [PATCH 1/5] check: use _try_scratch_mount instead of _scratch_mount to mount SCRATCH_DEV
Date: Sat, 29 Dec 2018 10:34:48 +0800 [thread overview]
Message-ID: <20181229023452.28074-2-houtao1@huawei.com> (raw)
In-Reply-To: <20181229023452.28074-1-houtao1@huawei.com>
Else there won't be any error messages when mounting SCRATCH_DEV failed,
because _scratch_mount exits early by invoking _fail.
Signed-off-by: Hou Tao <houtao1@huawei.com>
---
check | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/check b/check
index e85f40ac..e4d76737 100755
--- a/check
+++ b/check
@@ -607,7 +607,7 @@ for section in $HOST_OPTIONS_SECTIONS; do
# call the overridden mount - make sure the FS mounts with
# the same options that we'll mount with later.
- if ! _scratch_mount >$tmp.err 2>&1
+ if ! _try_scratch_mount >$tmp.err 2>&1
then
echo "our local mount routine ..."
cat $tmp.err
--
2.16.2.dirty
next prev parent reply other threads:[~2018-12-29 2:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 2:34 [PATCH 0/5] tiny fixes for xfstests Hou Tao
2018-12-29 2:34 ` Hou Tao [this message]
2018-12-29 2:34 ` [PATCH 2/5] generic/019: check scratch device is a block device or not Hou Tao
2018-12-29 2:34 ` [PATCH 3/5] generic/131: wait until the server is ready Hou Tao
2018-12-29 8:14 ` Eryu Guan
2019-01-04 8:56 ` Hou Tao
2018-12-29 2:34 ` [PATCH 4/5] generic/466: explicitly request $SCRATCH_DEV to be a block device Hou Tao
2018-12-29 2:34 ` [PATCH 5/5] fsx: check ENOSYS in test_copy_range() Hou Tao
2018-12-29 8:16 ` Eryu Guan
2018-12-29 18:56 ` Darrick J. Wong
2019-01-04 8:57 ` Hou Tao
2018-12-29 18:53 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181229023452.28074-2-houtao1@huawei.com \
--to=houtao1@huawei.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox