From: Nikolay Borisov <nborisov@suse.com>
To: fstests@vger.kernel.org
Cc: guaneryu@gmail.com, Nikolay Borisov <nborisov@suse.com>
Subject: [PATCH] common/config: Always create RESULT_BASE
Date: Thu, 3 Jan 2019 12:01:35 +0200 [thread overview]
Message-ID: <20190103100135.24748-1-nborisov@suse.com> (raw)
Commit 7fc034868d5d ("common/config: create $RESULT_BASE before dumping kmemleak leaks")
inadvertently broke $RESULT_BASE dir creation since it changed the logic
to only create the directory only if this variable is not explicitly set
by the user. Fix this by ensuring RESULT_BASE is always created.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
common/config | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/common/config b/common/config
index fb664cf0a967..e2da9cfacbb5 100644
--- a/common/config
+++ b/common/config
@@ -663,11 +663,12 @@ get_next_config() {
# set default RESULT_BASE
if [ -z "$RESULT_BASE" ]; then
export RESULT_BASE="$here/results/"
- mkdir -p ${RESULT_BASE}
- if [ ! -d ${RESULT_BASE} ]; then
- echo "failed to create results directory $RESULT_BASE"
- exit 1
- fi
+ fi
+
+ mkdir -p ${RESULT_BASE}
+ if [ ! -d ${RESULT_BASE} ]; then
+ echo "failed to create results directory $RESULT_BASE"
+ exit 1
fi
if [ "$FSTYP" == "tmpfs" ]; then
--
2.7.4
next reply other threads:[~2019-01-03 10:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 10:01 Nikolay Borisov [this message]
2019-01-03 12:29 ` [PATCH] common/config: Always create RESULT_BASE Nikolay Borisov
2019-01-03 15:22 ` Eryu Guan
2019-01-03 21:56 ` Dave Chinner
2019-01-04 9:43 ` Eryu Guan
2019-01-04 9:54 ` Nikolay Borisov
2019-01-04 13:19 ` Eryu Guan
2019-01-06 17:47 ` Darrick J. Wong
2019-01-06 18:08 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190103100135.24748-1-nborisov@suse.com \
--to=nborisov@suse.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox