Re: [PATCH] common/config: Always create RESULT_BASE

[Nikolay Borisov <nborisov@suse.com>]

On 3.01.19 г. 12:01 ч., Nikolay Borisov wrote:
> Commit 7fc034868d5d ("common/config: create $RESULT_BASE before dumping kmemleak leaks")
> inadvertently broke $RESULT_BASE dir creation since it changed the logic
> to only create the directory only if this variable is not explicitly set
> by the user. Fix this by ensuring RESULT_BASE is always created.
> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

Eryu,

I think Johannes' commit should actually be reverted. Currently
get_next_config is called at the beginning of the section code _AFTER_
_init_kmemleak so it's not really fixing the problem that Johannes
described. So care to revert his commit ?

> ---
>  common/config | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/common/config b/common/config
> index fb664cf0a967..e2da9cfacbb5 100644
> --- a/common/config
> +++ b/common/config
> @@ -663,11 +663,12 @@ get_next_config() {
>  	# set default RESULT_BASE
>  	if [ -z "$RESULT_BASE" ]; then
>  		export RESULT_BASE="$here/results/"
> -		mkdir -p ${RESULT_BASE}
> -		if [ ! -d ${RESULT_BASE} ]; then
> -			echo "failed to create results directory $RESULT_BASE"
> -			exit 1
> -		fi
> +	fi
> +
> +	mkdir -p ${RESULT_BASE}
> +	if [ ! -d ${RESULT_BASE} ]; then
> +		echo "failed to create results directory $RESULT_BASE"
> +		exit 1
>  	fi
>  
>  	if [ "$FSTYP" == "tmpfs" ]; then
>