From: Eryu Guan <guaneryu@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] xfs/252: requires fallocate support for preallocation
Date: Sun, 10 Feb 2019 17:30:19 +0800 [thread overview]
Message-ID: <20190210093019.GS2713@desktop> (raw)
In-Reply-To: <20190205184816.20330-1-hch@lst.de>
On Tue, Feb 05, 2019 at 07:48:16PM +0100, Christoph Hellwig wrote:
> xfs/252 has a few feature tests, but misses checking for preallocation
> support. Because of that it will fail instead of not being run for
> and XFS file system in always COW mode.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> tests/xfs/252 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/xfs/252 b/tests/xfs/252
> index df795b81..42650ad1 100755
> --- a/tests/xfs/252
> +++ b/tests/xfs/252
> @@ -31,6 +31,7 @@ _supported_fs xfs
> _supported_os Linux
>
> _require_test
> +_require_xfs_io_command "fallocate"
The xfs_io command should be "falloc", fixed on commit :)
Thanks,
Eryu
> _require_xfs_io_command "fpunch"
> _require_xfs_io_command "fiemap"
>
> --
> 2.20.1
>
prev parent reply other threads:[~2019-02-10 9:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 18:48 [PATCH] xfs/252: requires fallocate support for preallocation Christoph Hellwig
2019-02-10 9:30 ` Eryu Guan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190210093019.GS2713@desktop \
--to=guaneryu@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox