* [PATCH] xfs/252: requires fallocate support for preallocation
@ 2019-02-05 18:48 Christoph Hellwig
2019-02-10 9:30 ` Eryu Guan
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2019-02-05 18:48 UTC (permalink / raw)
To: fstests
xfs/252 has a few feature tests, but misses checking for preallocation
support. Because of that it will fail instead of not being run for
and XFS file system in always COW mode.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
tests/xfs/252 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/xfs/252 b/tests/xfs/252
index df795b81..42650ad1 100755
--- a/tests/xfs/252
+++ b/tests/xfs/252
@@ -31,6 +31,7 @@ _supported_fs xfs
_supported_os Linux
_require_test
+_require_xfs_io_command "fallocate"
_require_xfs_io_command "fpunch"
_require_xfs_io_command "fiemap"
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs/252: requires fallocate support for preallocation
2019-02-05 18:48 [PATCH] xfs/252: requires fallocate support for preallocation Christoph Hellwig
@ 2019-02-10 9:30 ` Eryu Guan
0 siblings, 0 replies; 2+ messages in thread
From: Eryu Guan @ 2019-02-10 9:30 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: fstests
On Tue, Feb 05, 2019 at 07:48:16PM +0100, Christoph Hellwig wrote:
> xfs/252 has a few feature tests, but misses checking for preallocation
> support. Because of that it will fail instead of not being run for
> and XFS file system in always COW mode.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> tests/xfs/252 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/xfs/252 b/tests/xfs/252
> index df795b81..42650ad1 100755
> --- a/tests/xfs/252
> +++ b/tests/xfs/252
> @@ -31,6 +31,7 @@ _supported_fs xfs
> _supported_os Linux
>
> _require_test
> +_require_xfs_io_command "fallocate"
The xfs_io command should be "falloc", fixed on commit :)
Thanks,
Eryu
> _require_xfs_io_command "fpunch"
> _require_xfs_io_command "fiemap"
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-10 9:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-05 18:48 [PATCH] xfs/252: requires fallocate support for preallocation Christoph Hellwig
2019-02-10 9:30 ` Eryu Guan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox