public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <guaneryu@gmail.com>
To: Ronnie Sahlberg <lsahlber@redhat.com>
Cc: fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH] Add new xattr test 532
Date: Wed, 6 Mar 2019 20:52:34 +0800	[thread overview]
Message-ID: <20190306125234.GJ2824@desktop> (raw)
In-Reply-To: <20190305043613.11752-1-lsahlber@redhat.com>

On Tue, Mar 05, 2019 at 02:36:13PM +1000, Ronnie Sahlberg wrote:
> This test is cloned from 097 but has had all the tests for trusted.*
> removed.
> This makes it possible to use this test on filesystems that can only
> provide user.* xattrs such as CIFS.
> 
> Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>

Sorry I missed your last patch of this clone..

Do I need to do special setup for CIFS to support xattr? Currently I got
test _notrun because attrs are not supported by CIFS. I was mounting a
local samba server with

-o vers=3.0 -o username=user,password=passwd,sfu -o context=system_u:object_r:root_t:s0 //localhost/scratch /mnt/scratch

Kernel is 5.0.0-rc7.

But instead of cloning all the user.* xattr tests, I think it's better
to split generic/097, leave all trusted.* xattr tests there and move all
user.* xattr tests to this new test. So we don't have to maintain two
copys of the same user.* xattr tests.

Thanks,
Eryu

  reply	other threads:[~2019-03-06 12:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-05  4:36 [PATCH] Add new xattr test 532 Ronnie Sahlberg
2019-03-06 12:52 ` Eryu Guan [this message]
2019-03-07  2:46   ` Ronnie Sahlberg
2019-03-08  2:42     ` Eryu Guan
2019-03-08  3:01       ` ronnie sahlberg
2019-03-08  3:09         ` Eryu Guan
  -- strict thread matches above, loose matches on Subject: below --
2019-03-05  4:38 Ronnie Sahlberg
2019-03-06 21:55 ` Dave Chinner
2019-03-07  4:08 Ronnie Sahlberg
2019-03-08  3:34 Ronnie Sahlberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190306125234.GJ2824@desktop \
    --to=guaneryu@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=lsahlber@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox